Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event Notifications: enabled private endpoint #4989

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Event Notifications: enabled private endpoint #4989

merged 1 commit into from
Feb 6, 2024

Conversation

pankaj-kumar34
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@pankaj-kumar34
Copy link
Author

Hi @obai-1, can you review and merge this PR. We have customer waiting for this fix. Thank you.

@hkantare
Copy link
Collaborator

hkantare commented Dec 18, 2023 •
edited
Loading

Can you please add testcases results
@pankaj-kumar34

@pankaj-kumar34
Copy link
Author

pankaj-kumar34 commented Jan 12, 2024 •
edited
Loading

I have test Private and Public endpoint both are working as expected.
image

@hkantare

@hkantare hkantare merged commit 9d2f3ae into IBM-Cloud:master Feb 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pankaj-kumar34 @hkantare