Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CD scc doc updates #4984

Merged
merged 2 commits into from
Jan 10, 2024
Merged

CD scc doc updates #4984

merged 2 commits into from
Jan 10, 2024

Conversation

gmarjoram
Copy link
Contributor

@gmarjoram gmarjoram commented Dec 12, 2023 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

make testacc TEST=./ibm/service/cdtoolchain TESTARGS='-run=TestAccIBMCdToolchainToolSecuritycompliance*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/cdtoolchain -v -run=TestAccIBMCdToolchainToolSecuritycompliance* -timeout 100m
=== RUN   TestAccIBMCdToolchainToolSecuritycomplianceDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolSecuritycomplianceDataSourceBasic (35.40s)
=== RUN   TestAccIBMCdToolchainToolSecuritycomplianceDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolSecuritycomplianceDataSourceAllArgs (33.01s)
=== RUN   TestAccIBMCdToolchainToolSecuritycomplianceBasic
--- PASS: TestAccIBMCdToolchainToolSecuritycomplianceBasic (26.73s)
=== RUN   TestAccIBMCdToolchainToolSecuritycomplianceAllArgs
--- PASS: TestAccIBMCdToolchainToolSecuritycomplianceAllArgs (50.69s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cdtoolchain	150.930s

...

maire-kehoe
maire-kehoe approved these changes Jan 8, 2024
View reviewed changes
Copy link

@maire-kehoe maire-kehoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maire-kehoe
maire-kehoe approved these changes Jan 9, 2024
View reviewed changes
Copy link

@maire-kehoe maire-kehoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmarjoram gmarjoram marked this pull request as ready for review January 9, 2024 15:54
@hkantare hkantare merged commit ba2dedb into IBM-Cloud:master Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare approved these changes

@maire-kehoe maire-kehoe maire-kehoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmarjoram @maire-kehoe @hkantare