Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new service mqcloud #4960

Merged
merged 1 commit into from
Dec 12, 2023
Merged

feat: add new service mqcloud #4960

merged 1 commit into from
Dec 12, 2023

Conversation

shuaibbapputty
Copy link
Contributor

@shuaibbapputty shuaibbapputty commented Dec 1, 2023 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Introduce ibm_mqcloud service with these resources.

  • mqcloud_queue_manager
  • mqcloud_application
  • mqcloud_user
  • mqcloud_keystore_certificate
  • mqcloud_truststore_certificate

Output from acceptance testing:

> make testacc TEST=./ibm/service/mqcloud/...
=== RUN   TestAccIbmMqcloudApplicationDataSourceBasic
--- PASS: TestAccIbmMqcloudApplicationDataSourceBasic (34.09s)
=== RUN   TestAccIbmMqcloudApplicationDataSourceAllArgs
--- PASS: TestAccIbmMqcloudApplicationDataSourceAllArgs (30.01s)
=== RUN   TestAccIbmMqcloudKeystoreCertificateDataSourceBasic
--- PASS: TestAccIbmMqcloudKeystoreCertificateDataSourceBasic (44.28s)
=== RUN   TestAccIbmMqcloudKeystoreCertificateDataSourceAllArgs
--- PASS: TestAccIbmMqcloudKeystoreCertificateDataSourceAllArgs (47.58s)
=== RUN   TestAccIbmMqcloudQueueManagerStatusDataSourceBasic
=== PAUSE TestAccIbmMqcloudQueueManagerStatusDataSourceBasic
=== RUN   TestAccIbmMqcloudQueueManagerDataSourceBasic
=== PAUSE TestAccIbmMqcloudQueueManagerDataSourceBasic
=== RUN   TestAccIbmMqcloudQueueManagerDataSourceAllArgs
=== PAUSE TestAccIbmMqcloudQueueManagerDataSourceAllArgs
=== RUN   TestAccIbmMqcloudTruststoreCertificateDataSourceBasic
--- PASS: TestAccIbmMqcloudTruststoreCertificateDataSourceBasic (43.26s)
=== RUN   TestAccIbmMqcloudTruststoreCertificateDataSourceAllArgs
--- PASS: TestAccIbmMqcloudTruststoreCertificateDataSourceAllArgs (43.42s)
=== RUN   TestAccIbmMqcloudUserDataSourceBasic
--- PASS: TestAccIbmMqcloudUserDataSourceBasic (35.73s)
=== RUN   TestAccIbmMqcloudUserDataSourceAllArgs
--- PASS: TestAccIbmMqcloudUserDataSourceAllArgs (38.38s)
=== RUN   TestAccIbmMqcloudApplicationBasic
--- PASS: TestAccIbmMqcloudApplicationBasic (35.67s)
=== RUN   TestAccIbmMqcloudApplicationAllArgs
--- PASS: TestAccIbmMqcloudApplicationAllArgs (38.85s)
=== RUN   TestAccIbmMqcloudKeystoreCertificateBasic
--- PASS: TestAccIbmMqcloudKeystoreCertificateBasic (47.55s)
=== RUN   TestAccIbmMqcloudKeystoreCertificateAllArgs
--- PASS: TestAccIbmMqcloudKeystoreCertificateAllArgs (51.08s)
=== RUN   TestAccIbmMqcloudQueueManagerBasic
=== PAUSE TestAccIbmMqcloudQueueManagerBasic
=== RUN   TestAccIbmMqcloudQueueManagerAllArgs
=== PAUSE TestAccIbmMqcloudQueueManagerAllArgs
=== RUN   TestAccIbmMqcloudTruststoreCertificateBasic
--- PASS: TestAccIbmMqcloudTruststoreCertificateBasic (47.99s)
=== RUN   TestAccIbmMqcloudTruststoreCertificateAllArgs
--- PASS: TestAccIbmMqcloudTruststoreCertificateAllArgs (48.27s)
=== RUN   TestAccIbmMqcloudUserBasic
--- PASS: TestAccIbmMqcloudUserBasic (26.36s)
=== RUN   TestAccIbmMqcloudUserAllArgs
--- PASS: TestAccIbmMqcloudUserAllArgs (31.26s)
=== CONT  TestAccIbmMqcloudQueueManagerStatusDataSourceBasic
=== CONT  TestAccIbmMqcloudQueueManagerBasic
=== CONT  TestAccIbmMqcloudQueueManagerDataSourceAllArgs
=== CONT  TestAccIbmMqcloudQueueManagerDataSourceBasic
The queue manager is currently in the initializing state ....
The queue manager is currently in the initializing state ....
The queue manager is currently in the initializing state ....
--- PASS: TestAccIbmMqcloudQueueManagerStatusDataSourceBasic (27.12s)
=== CONT  TestAccIbmMqcloudQueueManagerAllArgs
The queue manager is currently in the initializing state ....
The queue manager is currently in the initializing state ....
The queue manager is currently in the initializing state ....
The queue manager is currently in the initializing state ....
The queue manager is currently in the initializing state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the initializing state ....
The queue manager is currently in the initializing state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the initializing state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the running state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the running state ....
The queue manager is currently in the running state ....
The queue manager is currently in the running state ....
--- PASS: TestAccIbmMqcloudQueueManagerDataSourceBasic (287.96s)
The queue manager is currently in the upgrading_version state ....
--- PASS: TestAccIbmMqcloudQueueManagerBasic (319.60s)
--- PASS: TestAccIbmMqcloudQueueManagerDataSourceAllArgs (320.02s)
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the running state ....
--- PASS: TestAccIbmMqcloudQueueManagerAllArgs (598.01s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/mqcloud 1270.072s

hkantare
hkantare reviewed Dec 5, 2023
View reviewed changes
ibm/conns/config.go Outdated Show resolved Hide resolved
ibm/conns/config.go Outdated Show resolved Hide resolved
ibm/service/mqcloud/data_source_ibm_mqcloud_queue_manager.go Outdated Show resolved Hide resolved
ibm/service/mqcloud/resource_ibm_mqcloud_queue_manager.go Show resolved Hide resolved
ibm/service/mqcloud/resource_ibm_mqcloud_queue_manager.go Outdated Show resolved Hide resolved
ibm/service/mqcloud/utils.go Outdated Show resolved Hide resolved
@shuaibbapputty
Copy link
Contributor Author

shuaibbapputty commented Dec 7, 2023 •
edited
Loading

Fixed the review comments.

Now we have these resources

  • mqcloud_queue_manager
  • mqcloud_application
  • mqcloud_user
  • mqcloud_keystore_certificate
  • mqcloud_truststore_certificate
>make testacc TEST=./ibm/service/mqcloud/...
=== RUN   TestAccIbmMqcloudApplicationDataSourceBasic
--- PASS: TestAccIbmMqcloudApplicationDataSourceBasic (34.09s)
=== RUN   TestAccIbmMqcloudApplicationDataSourceAllArgs
--- PASS: TestAccIbmMqcloudApplicationDataSourceAllArgs (30.01s)
=== RUN   TestAccIbmMqcloudKeystoreCertificateDataSourceBasic
--- PASS: TestAccIbmMqcloudKeystoreCertificateDataSourceBasic (44.28s)
=== RUN   TestAccIbmMqcloudKeystoreCertificateDataSourceAllArgs
--- PASS: TestAccIbmMqcloudKeystoreCertificateDataSourceAllArgs (47.58s)
=== RUN   TestAccIbmMqcloudQueueManagerStatusDataSourceBasic
=== PAUSE TestAccIbmMqcloudQueueManagerStatusDataSourceBasic
=== RUN   TestAccIbmMqcloudQueueManagerDataSourceBasic
=== PAUSE TestAccIbmMqcloudQueueManagerDataSourceBasic
=== RUN   TestAccIbmMqcloudQueueManagerDataSourceAllArgs
=== PAUSE TestAccIbmMqcloudQueueManagerDataSourceAllArgs
=== RUN   TestAccIbmMqcloudTruststoreCertificateDataSourceBasic
--- PASS: TestAccIbmMqcloudTruststoreCertificateDataSourceBasic (43.26s)
=== RUN   TestAccIbmMqcloudTruststoreCertificateDataSourceAllArgs
--- PASS: TestAccIbmMqcloudTruststoreCertificateDataSourceAllArgs (43.42s)
=== RUN   TestAccIbmMqcloudUserDataSourceBasic
--- PASS: TestAccIbmMqcloudUserDataSourceBasic (35.73s)
=== RUN   TestAccIbmMqcloudUserDataSourceAllArgs
--- PASS: TestAccIbmMqcloudUserDataSourceAllArgs (38.38s)
=== RUN   TestAccIbmMqcloudApplicationBasic
--- PASS: TestAccIbmMqcloudApplicationBasic (35.67s)
=== RUN   TestAccIbmMqcloudApplicationAllArgs
--- PASS: TestAccIbmMqcloudApplicationAllArgs (38.85s)
=== RUN   TestAccIbmMqcloudKeystoreCertificateBasic
--- PASS: TestAccIbmMqcloudKeystoreCertificateBasic (47.55s)
=== RUN   TestAccIbmMqcloudKeystoreCertificateAllArgs
--- PASS: TestAccIbmMqcloudKeystoreCertificateAllArgs (51.08s)
=== RUN   TestAccIbmMqcloudQueueManagerBasic
=== PAUSE TestAccIbmMqcloudQueueManagerBasic
=== RUN   TestAccIbmMqcloudQueueManagerAllArgs
=== PAUSE TestAccIbmMqcloudQueueManagerAllArgs
=== RUN   TestAccIbmMqcloudTruststoreCertificateBasic
--- PASS: TestAccIbmMqcloudTruststoreCertificateBasic (47.99s)
=== RUN   TestAccIbmMqcloudTruststoreCertificateAllArgs
--- PASS: TestAccIbmMqcloudTruststoreCertificateAllArgs (48.27s)
=== RUN   TestAccIbmMqcloudUserBasic
--- PASS: TestAccIbmMqcloudUserBasic (26.36s)
=== RUN   TestAccIbmMqcloudUserAllArgs
--- PASS: TestAccIbmMqcloudUserAllArgs (31.26s)
=== CONT  TestAccIbmMqcloudQueueManagerStatusDataSourceBasic
=== CONT  TestAccIbmMqcloudQueueManagerBasic
=== CONT  TestAccIbmMqcloudQueueManagerDataSourceAllArgs
=== CONT  TestAccIbmMqcloudQueueManagerDataSourceBasic
The queue manager is currently in the initializing state ....
The queue manager is currently in the initializing state ....
The queue manager is currently in the initializing state ....
--- PASS: TestAccIbmMqcloudQueueManagerStatusDataSourceBasic (27.12s)
=== CONT  TestAccIbmMqcloudQueueManagerAllArgs
The queue manager is currently in the initializing state ....
The queue manager is currently in the initializing state ....
The queue manager is currently in the initializing state ....
The queue manager is currently in the initializing state ....
The queue manager is currently in the initializing state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the initializing state ....
The queue manager is currently in the initializing state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the initializing state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the running state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the deploying state ....
The queue manager is currently in the running state ....
The queue manager is currently in the running state ....
The queue manager is currently in the running state ....
--- PASS: TestAccIbmMqcloudQueueManagerDataSourceBasic (287.96s)
The queue manager is currently in the upgrading_version state ....
--- PASS: TestAccIbmMqcloudQueueManagerBasic (319.60s)
--- PASS: TestAccIbmMqcloudQueueManagerDataSourceAllArgs (320.02s)
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the upgrading_version state ....
The queue manager is currently in the running state ....
--- PASS: TestAccIbmMqcloudQueueManagerAllArgs (598.01s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/mqcloud 1270.072s

@shuaibbapputty shuaibbapputty marked this pull request as ready for review December 8, 2023 07:53
@hkantare
Copy link
Collaborator

Resolve conflicts on above files

@shuaibbapputty
Copy link
Contributor Author

shuaibbapputty commented Dec 12, 2023 •
edited
Loading

We had resolved the conflicts and review comments and ran the acc test once again, with the latest changes

=== RUN   TestAccIbmMqcloudApplicationDataSourceBasic
--- PASS: TestAccIbmMqcloudApplicationDataSourceBasic (53.41s)
=== RUN   TestAccIbmMqcloudApplicationDataSourceAllArgs
--- PASS: TestAccIbmMqcloudApplicationDataSourceAllArgs (41.24s)
=== RUN   TestAccIbmMqcloudKeystoreCertificateDataSourceBasic
--- PASS: TestAccIbmMqcloudKeystoreCertificateDataSourceBasic (55.50s)
=== RUN   TestAccIbmMqcloudKeystoreCertificateDataSourceAllArgs
--- PASS: TestAccIbmMqcloudKeystoreCertificateDataSourceAllArgs (53.99s)
=== RUN   TestAccIbmMqcloudQueueManagerStatusDataSourceBasic
=== PAUSE TestAccIbmMqcloudQueueManagerStatusDataSourceBasic
=== RUN   TestAccIbmMqcloudQueueManagerDataSourceBasic
=== PAUSE TestAccIbmMqcloudQueueManagerDataSourceBasic
=== RUN   TestAccIbmMqcloudQueueManagerDataSourceAllArgs
=== PAUSE TestAccIbmMqcloudQueueManagerDataSourceAllArgs
=== RUN   TestAccIbmMqcloudTruststoreCertificateDataSourceBasic
--- PASS: TestAccIbmMqcloudTruststoreCertificateDataSourceBasic (49.71s)
=== RUN   TestAccIbmMqcloudTruststoreCertificateDataSourceAllArgs
--- PASS: TestAccIbmMqcloudTruststoreCertificateDataSourceAllArgs (43.17s)
=== RUN   TestAccIbmMqcloudUserDataSourceBasic
--- PASS: TestAccIbmMqcloudUserDataSourceBasic (41.22s)
=== RUN   TestAccIbmMqcloudUserDataSourceAllArgs
--- PASS: TestAccIbmMqcloudUserDataSourceAllArgs (39.58s)
=== RUN   TestAccIbmMqcloudApplicationBasic
--- PASS: TestAccIbmMqcloudApplicationBasic (35.25s)
=== RUN   TestAccIbmMqcloudApplicationAllArgs
--- PASS: TestAccIbmMqcloudApplicationAllArgs (43.11s)
=== RUN   TestAccIbmMqcloudKeystoreCertificateBasic
--- PASS: TestAccIbmMqcloudKeystoreCertificateBasic (48.02s)
=== RUN   TestAccIbmMqcloudKeystoreCertificateAllArgs
--- PASS: TestAccIbmMqcloudKeystoreCertificateAllArgs (51.40s)
=== RUN   TestAccIbmMqcloudQueueManagerBasic
=== PAUSE TestAccIbmMqcloudQueueManagerBasic
=== RUN   TestAccIbmMqcloudQueueManagerAllArgs
=== PAUSE TestAccIbmMqcloudQueueManagerAllArgs
=== RUN   TestAccIbmMqcloudTruststoreCertificateBasic
--- PASS: TestAccIbmMqcloudTruststoreCertificateBasic (39.13s)
=== RUN   TestAccIbmMqcloudTruststoreCertificateAllArgs
--- PASS: TestAccIbmMqcloudTruststoreCertificateAllArgs (46.67s)
=== RUN   TestAccIbmMqcloudUserBasic
--- PASS: TestAccIbmMqcloudUserBasic (39.19s)
=== RUN   TestAccIbmMqcloudUserAllArgs
--- PASS: TestAccIbmMqcloudUserAllArgs (43.04s)
=== CONT  TestAccIbmMqcloudQueueManagerBasic
=== CONT  TestAccIbmMqcloudQueueManagerStatusDataSourceBasic
=== CONT  TestAccIbmMqcloudQueueManagerDataSourceAllArgs
=== CONT  TestAccIbmMqcloudQueueManagerDataSourceBasic
--- PASS: TestAccIbmMqcloudQueueManagerStatusDataSourceBasic (34.88s)
=== CONT  TestAccIbmMqcloudQueueManagerAllArgs
--- PASS: TestAccIbmMqcloudQueueManagerDataSourceBasic (322.30s)
--- PASS: TestAccIbmMqcloudQueueManagerBasic (364.36s)
--- PASS: TestAccIbmMqcloudQueueManagerDataSourceAllArgs (383.86s)
--- PASS: TestAccIbmMqcloudQueueManagerAllArgs (629.05s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/mqcloud 1366.661s

@hkantare hkantare merged commit 6aa6b14 into IBM-Cloud:master Dec 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shuaibbapputty @hkantare