Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Power Workspace/s and Datacenter/s DataSource Documentation #4904

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Update Power Workspace/s and Datacenter/s DataSource Documentation #4904

merged 5 commits into from
Nov 23, 2023

Conversation

michaelkad
Copy link
Collaborator

  • Update doc for get and getall workspace and datacenter

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@michaelkad
Update Power Workspace/s and Datacenter/s DataSource
c33db2e 
- Update doc for get and getall workspace and datacenter
@michaelkad
Copy link
Collaborator Author

@hkantare @yussufsh Could you help with reviewing this PR please?

@yussufsh
Copy link
Collaborator

@hkantare @yussufsh Could you help with reviewing this PR please?

There are some pending comments above.

@michaelkad
Copy link
Collaborator Author

@yussufsh I do not think there has been any comments on this PR. If you were in the middle of one, please do resubmit.

@yussufsh
Copy link
Collaborator

@yussufsh I do not think there has been any comments on this PR. If you were in the middle of one, please do resubmit.

You are right.. Sorry :-(

@michaelkad
Copy link
Collaborator Author

@yussufsh I do not think there has been any comments on this PR. If you were in the middle of one, please do resubmit.

You are right.. Sorry :-(

You are good. I will update go.mod

@michaelkad michaelkad requested a review from yussufsh November 21, 2023 13:59
yussufsh
yussufsh approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@hkantare please help merge this one.

@hkantare
Copy link
Collaborator

fix the conflicts

@michaelkad
Copy link
Collaborator Author

fix the conflicts

@hkantare The conflict has been resolved.

@hkantare hkantare merged commit 06a9ed7 into master Nov 23, 2023
2 checks passed
@hkantare hkantare deleted the ws_dc_doc_update branch November 23, 2023 14:08
@yussufsh yussufsh added the service/Power Systems Issues related to Power Systems label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@hkantare hkantare Awaiting requested review from hkantare

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelkad @yussufsh @hkantare