Terraform Support for Satellite Storage Configurations & Assignments #4775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aayushsss1
force-pushed
the
satellite-storage-terraform
branch
from
36287bc to
9c2295f
Compare
hkantare
reviewed
Sep 14, 2023
| }, | ||
| "storage_class_parameters": { | ||
| Type: schema.TypeList, | ||
| Optional: true, |
There was a problem hiding this comment.
In datasource is this optional or computed?
There was a problem hiding this comment.
Sorry I'll make it computed
| Computed: true, | ||
| Description: "The storage configuration parameters depending on the storage template.", | ||
| }, | ||
| "user_secret_parameters": { |
There was a problem hiding this comment.
This because we're unable to get the secrets from the server side, I take it as an input through terraform and store it in the state file
There was a problem hiding this comment.
Generally users may not send them in tf files for datasources. You can completed remove this from schema
| } | ||
| result, _, err := satClient.GetStorageConfiguration(getStorageConfigurationOptions) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
As per the code I see location and config_name only as inputes
Remaining all shd be computed
aayushsss1
force-pushed
the
satellite-storage-terraform
branch
from
82021ce to
1172ac9
Compare
|
Fix the conflict files |
aayushsss1
force-pushed
the
satellite-storage-terraform
branch
from
6111e25 to
c01d262
Compare
hkantare
reviewed
Sep 15, 2023
go.mod
Outdated
| github.com/IBM-Cloud/container-services-go-sdk v0.0.0-20230118060037-101bda076037 | ||
| github.com/IBM-Cloud/power-go-client v1.2.4 | ||
| github.com/IBM-Cloud/container-services-go-sdk v0.0.0-20230822142550-30562e113de9 | ||
| github.com/IBM-Cloud/power-go-client v1.2.2 |
There was a problem hiding this comment.
You are rolling back the changed of this PR
https://github.com/IBM-Cloud/terraform-provider-ibm/pull/4766/files
create & validate create and validate Read & Create Function Satellite Config Terraform satellite storage final assignment-creation read function assignment complete sat-storage create changed read changed update & delete modified review comments regex changed final changes delete assignments param added storage configuration final add assignments to groups data sources for config and assignment added storage configuration enhancements storage configuration design updated storage configuration data source updated storage configuration data source updated - 1 satellite-storage docs added comments added secrets updated sensitive attribute added changed storage class param to computed secrets baseline updated secrets updated removed user secret parameters from config data source
aayushsss1
force-pushed
the
satellite-storage-terraform
branch
from
87f417c to
7dc3743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now allow users to create and manage the lifecycle of storage configurations and assignments through terraform.
Data sources added
Resources added
Documentation, Unit Tests and the Website changes are added as per
With this you can create storage configurations that can be consistently assigned, updated, and managed across the clusters, service clusters, and cluster groups in your satellite location.
Community Note
Relates OR Closes #0000
Output from acceptance testing: