Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for elasticsearch #179

Merged
merged 10 commits into from
Jul 29, 2024
Merged

Add support for elasticsearch #179

merged 10 commits into from
Jul 29, 2024

Conversation

YuChinKoo
Copy link
Collaborator

@YuChinKoo YuChinKoo commented May 7, 2024

Added

  • Support for service databases-for-elasticsearch, under resource ibm_database.

Testing

Unit Testing

Results:

go test -v ./internal/providers/terraform/ibm/database_test.go

=== RUN   TestDatabase
=== PAUSE TestDatabase
=== CONT  TestDatabase
=== RUN   TestDatabase/HCL
    tftest.go:213: Couldn't copy terraform init cache from /Users/eugenekoo/Documents/VSCode/FinOps/infracost-cli/.test_cache/terraform_init
Configured IAM URL https://iam.cloud.ibm.com
=== RUN   TestDatabase/Terraform_CLI
    tftest.go:217: Couldn't copy terraform init cache from /Users/eugenekoo/Documents/VSCode/FinOps/infracost-cli/.test_cache/terraform_init
Configured IAM URL https://iam.cloud.ibm.com
--- PASS: TestDatabase (23.14s)
    --- PASS: TestDatabase/HCL (0.82s)
    --- PASS: TestDatabase/Terraform_CLI (22.33s)
PASS
ok      command-line-arguments  24.166s

@YuChinKoo YuChinKoo marked this pull request as ready for review May 8, 2024 14:05
@YuChinKoo YuChinKoo requested review from luisarojas and hiltol May 8, 2024 14:05
@luisarojas
Copy link
Collaborator

Should we also include the platinum plan? (standard is deprecated)

Screenshot 2024-05-08 at 4 14 42 PM

@YuChinKoo
Copy link
Collaborator Author

Should we also include the platinum plan? (standard is deprecated)

Screenshot 2024-05-08 at 4 14 42 PM

I'm not sure.. would like to get some thoughts about it.

The reason I didn't include it is because databases offers a 'standard' plan which can be of isolated or shared database. For example, you can choose between isolated (the user selects host flavor) or shared (all parameters can be set by the user) for postgres or elasticsearch. This is the 'standard' or the 'default' plan. For Elasticsearch, the 'default' plan is the enterprise plan, but ES also has another plan called platinum plan. In the platinum plan, the users can only select isolated database. This isolated database was not implemented when infracost support for postgres was added.. So I am not sure if this is something new or something i'll have to implement as well.

@hiltol
Copy link
Collaborator

hiltol commented May 14, 2024

Should we also include the platinum plan? (standard is deprecated)
Screenshot 2024-05-08 at 4 14 42 PM

I'm not sure.. would like to get some thoughts about it.

The reason I didn't include it is because databases offers a 'standard' plan which can be of isolated or shared database. For example, you can choose between isolated (the user selects host flavor) or shared (all parameters can be set by the user) for postgres or elasticsearch. This is the 'standard' or the 'default' plan. For Elasticsearch, the 'default' plan is the enterprise plan, but ES also has another plan called platinum plan. In the platinum plan, the users can only select isolated database. This isolated database was not implemented when infracost support for postgres was added.. So I am not sure if this is something new or something i'll have to implement as well.

Support for the platinum plan will need to be added. https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/database#sample-elasticsearch-platinum-instance

@hiltol hiltol merged commit 8183720 into master Jul 29, 2024
6 of 7 checks passed
@hiltol hiltol deleted the feat/db-for-es-support branch July 29, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants