Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DNS Services #178

Merged
merged 18 commits into from
May 14, 2024
Merged

Add support for DNS Services #178

merged 18 commits into from
May 14, 2024

Conversation

luisarojas
Copy link
Collaborator

@luisarojas luisarojas commented May 7, 2024

Added

  • Support for service dns-svcs, under resource ibm_resource_instance.

Testing

Unit Testing

Results:

❯ go test -v ./internal/providers/terraform/ibm/resource_instance_test.go
=== RUN   TestResourceInstance
=== PAUSE TestResourceInstance
=== CONT  TestResourceInstance
=== RUN   TestResourceInstance/HCL
No IBM_CLOUD_IAM_URL credential set, defaults to production.
=== RUN   TestResourceInstance/Terraform_CLI
No IBM_CLOUD_IAM_URL credential set, defaults to production.
--- PASS: TestResourceInstance (30.13s)
    --- PASS: TestResourceInstance/HCL (1.61s)
    --- PASS: TestResourceInstance/Terraform_CLI (28.52s)
PASS
ok      command-line-arguments  31.086s

Where the result for this resource is:

 ibm_resource_instance.dns_svcs_standard                                                                                                     
 ├─ Additional Zones                                                                         1  Zones                                  $0.54 
 ├─ Pool Hours                                                                               1  Hours                                  $0.04 
 ├─ GLB Instance Hours                                                                       1  Hours                                  $0.04 
 ├─ Health Checks                                                                            1  Health Checks                          $1.08 
 ├─ Custom Resolver Location Hours                                                           1  Hours                                  $0.13 
 ├─ Million Custom Resolver External Queries (first 10 Million Queries)                     10  Million Queries                        $4.31 
 ├─ Million Custom Resolver External Queries (over 10 Million Queries)                       1  Million Queries                        $0.22 
 └─ Additional Million DNS Queries (first 999 Million Queries)                             999  Million Queries                      $645.16 
 └─ Additional Million DNS Queries (over 999 Million Queries)                                1  Million Queries                        $0.32 

Warning

I noticed that for test resources ibm_resource_instance.resource_instance_activity_tracker_7day_no_usage, ibm_resource_instance.resource_instance_logdna_7day_no_usage, ibm_resource_instance.resource_instance_monitoring_graduated_no_usage, ibm_resource_instance.wml_instance_standard some or all units show: "Monthly cost depends on usage: ...".

We'll need to address that in a future PR. Might just be a matter of adjusting the units used.

Regression Testing

Results:

================================================================================
Test Suites: 2 passed, 2 total
Tests:       11 passed, 11 total
Snapshots:   0 total
Time:        25.898 s
Ran all test suites matching /sanity*/i.

@luisarojas luisarojas self-assigned this May 7, 2024
@luisarojas luisarojas added the enhancement New feature or request label May 7, 2024
@luisarojas luisarojas marked this pull request as ready for review May 7, 2024 22:27
@luisarojas luisarojas requested review from YuChinKoo and hiltol May 7, 2024 22:27
@luisarojas luisarojas requested a review from hiltol May 8, 2024 17:13
@luisarojas luisarojas requested a review from hiltol May 14, 2024 14:01
internal/resources/ibm/resource_instance_dns-svcs.go Outdated Show resolved Hide resolved
internal/resources/ibm/resource_instance_dns-svcs.go Outdated Show resolved Hide resolved
internal/resources/ibm/resource_instance_dns-svcs.go Outdated Show resolved Hide resolved
internal/resources/ibm/resource_instance_dns-svcs.go Outdated Show resolved Hide resolved
internal/resources/ibm/resource_instance_dns-svcs.go Outdated Show resolved Hide resolved
internal/resources/ibm/resource_instance_dns-svcs.go Outdated Show resolved Hide resolved
internal/resources/ibm/resource_instance_dns-svcs.go Outdated Show resolved Hide resolved
@luisarojas luisarojas requested a review from hiltol May 14, 2024 18:53
@luisarojas luisarojas requested a review from hiltol May 14, 2024 19:24
internal/resources/ibm/resource_instance.go Outdated Show resolved Hide resolved
internal/resources/ibm/resource_instance.go Outdated Show resolved Hide resolved
internal/resources/ibm/resource_instance.go Outdated Show resolved Hide resolved
@hiltol hiltol merged commit 8c3ab76 into master May 14, 2024
6 of 7 checks passed
@hiltol hiltol deleted the feat/add-support-dns-services branch May 14, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants