Adding Unit Test for OrganizationContact

[sayed4900]

This pull request implements a unit test for the OrganizationContact class by verifying its association with the Person and Organization classes. The test ensures that the OrganizationContact correctly stores and retrieves information about the associated Person and Organization.

[sayed4900]

@mozzy11 can you review this

[mozzy11]

Thanks @sayed4900 .
These are not intergration tests.
These are unit tests

[mozzy11]

see https://circleci.com/blog/unit-testing-vs-integration-testing/#:~:text=While%20unit%20tests%20always%20take,works%20in%20an%20integrated%20way.

[sayed4900]

Thanks @sayed4900 . These are not intergration tests. These are unit tests

I am sorry for this mistake, my confusion stemmed from the fact that I utilized data from the Person class to test the getPerson() method within the OrganizationContact class. But now it's clear for me why it is unit testing. Thanks for you @mozzy11

[sayed4900]

@mozzy11 should I close this pull request now?

[mozzy11]

Integration tests are designed to test the interaction between different components of a system, including external dependencies such as databases, file systems, APIs, etc. Therefore, when performing integration tests, the object being tested is not isolated from its persistence mechanism.

[mozzy11]

@sayed4900 , can you create a subfolder unitTests under src/test/java/org/openelisglobal and move these these there

[sayed4900]

@sayed4900 , can you create a subfolder unitTests under src/test/java/org/openelisglobal and move these these there

I create unitTests and under it I create organization folder, this good? or should I add all unit tests on this folder unitTestsdirectly ? I add folder organization to be organized as there are unit tests for address classes

[mozzy11]

Thanks @sayed4900 for attemtoing this.
For consistence ,
test methods should follow a naming convetion like
MethodName_ExpectedBehavior ie getOrganization_shouldReturnOrganization

[mozzy11]

Use a consistent naming convetion ie MethodName_ExpectedBehavior for the test Methods

[sayed4900]

Use a consistent naming convetion ie MethodName_ExpectedBehavior for the test Methods

Thanks @mozzy11
I will do it

[sayed4900]

Use a consistent naming convetion ie MethodName_ExpectedBehavior for the test Methods

Thanks @mozzy11 I will do it

Done