Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding API pagination to the Dashboard Order Lists #681 #873

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

parthnagdev
Copy link
Contributor

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

Added API pagination logic into Orders controller & Integrated Home Dashboard with API pagination functionality.
Before, all the data would go to the Frontend and would be paginated there only, now the data gets paginated by the API(100 results per bundle) and is sent in chunks/bundles to the Frontend for further pagination by the Frontend(i.e into 10, 20, 30, 50 or 100 results per page).

Video

Before

Recording.2024-03-23.132316.mp4

After
To test the pagination, property org.openelisglobal.paging.results.pageSize:2 was set to 2(i.e. 3 results per page), this test is shown below along with enabled/disabled Next and Previous Bundle buttons.

Recording.2024-03-23.133351.mp4

Related Issue

Issue - #681

https://github.com/orgs/I-TECH-UW/projects/6/views/1?pane=issue&itemId=49773666

* Added API pagination logic into Orders controller.
* Integrated Home Dashboard with API pagination functionality.
@parthnagdev
Copy link
Contributor Author

Hey @mozzy11 can you please review this change ?

@mozzy11 mozzy11 merged commit 592b234 into I-TECH-UW:develop_3x Mar 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants