-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e jobs for Chrome and firefox browsers #859
Conversation
…chemistryDashboard
👋 Hi, @tendomart, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tendomart, I believe some unnecessary changes were accidentally included in this PR from previous commits. Could you please take a look at it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are changes to this file necessary for adding end-to-end (e2e) jobs for Chrome and Firefox browsers? I think these came by mistake from a previous commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are changes to this file necessary for adding end-to-end (e2e) jobs for Chrome and Firefox browsers? I think these came by mistake from a previous commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are changes to this file necessary for adding end-to-end (e2e) jobs for Chrome and Firefox browsers? I think these came by mistake from a previous commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tendomart Thanks for working on this.
I think you have changes that are not needed in this PR
Yes thanks, @mozzy11 , I thought you would selectively pick the last commit. but will remove them sometime today. |
THanks @tendomart can you adress the CI Build failre and merge conflicts ? |
Alright @mozzy11 will find some time later today and look into resolving this |
👋 Hi, @tendomart, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Pull Requests Requirements
Summary
Add e2e jobs for Chrome and firefox browsers
These run the default inbuilt cypress browser, chrome and Firefox.
Should be triggered on push
tendomart@2251652
Hi @mozzy11 should focus on this commit
tendomart@2251652