Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e jobs for Chrome and firefox browsers #859

Closed
wants to merge 29 commits into from
Closed

Add e2e jobs for Chrome and firefox browsers #859

wants to merge 29 commits into from

Conversation

tendomart
Copy link
Contributor

Pull Requests Requirements

Summary

Add e2e jobs for Chrome and firefox browsers

These run the default inbuilt cypress browser, chrome and Firefox.

Should be triggered on push

tendomart@2251652

Hi @mozzy11 should focus on this commit
tendomart@2251652

@github-actions github-actions bot added the merge conflict Merge Conflicts label Mar 22, 2024
Copy link

👋 Hi, @tendomart,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Copy link
Contributor

@Ankit-Matth Ankit-Matth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tendomart, I believe some unnecessary changes were accidentally included in this PR from previous commits. Could you please take a look at it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are changes to this file necessary for adding end-to-end (e2e) jobs for Chrome and Firefox browsers? I think these came by mistake from a previous commit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are changes to this file necessary for adding end-to-end (e2e) jobs for Chrome and Firefox browsers? I think these came by mistake from a previous commit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are changes to this file necessary for adding end-to-end (e2e) jobs for Chrome and Firefox browsers? I think these came by mistake from a previous commit.

@github-actions github-actions bot removed the merge conflict Merge Conflicts label Mar 25, 2024
Copy link
Collaborator

@mozzy11 mozzy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tendomart Thanks for working on this.
I think you have changes that are not needed in this PR

@tendomart
Copy link
Contributor Author

Yes thanks, @mozzy11 , I thought you would selectively pick the last commit. but will remove them sometime today.

@mozzy11 mozzy11 changed the base branch from develop_3x to develop June 10, 2024 08:08
@mozzy11
Copy link
Collaborator

mozzy11 commented Jun 10, 2024

THanks @tendomart can you adress the CI Build failre and merge conflicts ?

@tendomart
Copy link
Contributor Author

Alright @mozzy11 will find some time later today and look into resolving this

@github-actions github-actions bot added the merge conflict Merge Conflicts label Jun 10, 2024
Copy link

👋 Hi, @tendomart,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict Merge Conflicts label Jun 12, 2024
@tendomart tendomart closed this by deleting the head repository Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants