Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed checkbox and search button overflow in ElectronicOrders #814

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Fixed checkbox and search button overflow in ElectronicOrders #814

merged 1 commit into from
Mar 18, 2024

Conversation

atulyadav745
Copy link
Contributor

@atulyadav745 atulyadav745 commented Mar 15, 2024 •
edited
Loading

This pull request addresses the issue #813 of checkbox and search button overflow in the ElectronicOrders component. The overflow problem occurred due to improper CSS styling, causing these elements to extend beyond their designated boundaries and overlap with adjacent content.

Changes Implemented:

Implemented CSS adjustments to constrain the checkbox and search button within their respective containers.
Ensured responsive design principles are followed to maintain proper layout across different viewport sizes.
Tested the changes to verify the resolution of the overflow issue and ensure compatibility across various devices and browsers.

Before:
Screen Shot 2024-03-15 at 23 47 16
After:
After

@mozzy11 This PR is ready to review, and let me know if any changes are required in this PR.
Thank You

sherrif10
sherrif10 reviewed Mar 16, 2024
View reviewed changes
frontend/src/components/eOrder/EOrderSearch.js
@@ -187,13 +188,15 @@ const EOrderSearch = ({
setAllInfo(e.currentTarget.checked);
}}
/>
<div className="formInlineDiv">
<div></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always share screen shot in tablet veiw

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always share screen shot in tablet veiw

Tablet view:
Screen Shot 2024-03-17 at 00 32 18

@sherrif10
Copy link
Contributor

Add a breadcrumb and we get this merged . checkout how it can be addressed here #810

@mozzy11 mozzy11 merged commit bdc339c into I-TECH-UW:develop_3x Mar 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherrif10 sherrif10 sherrif10 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atulyadav745 @sherrif10 @mozzy11