Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AddressPartTest.java #793

Merged
merged 8 commits into from
Mar 21, 2024

Conversation

sayed4900
Copy link
Contributor

@sayed4900 sayed4900 commented Mar 13, 2024

I have added a new unit test file, AddressPartTest.java, to the project. This test file includes tests for the AddressPart class to ensure its functionality behaves as expected.

Changes Made:

  • Created AddressPartTest.java in the src/test/java/org/openelisglobal/address/ directory.
  • Implemented unit tests for the AddressPart class methods, including setId(), setPartName(), and setDisplayOrder().
  • Added assertions to verify the correctness of the AddressPart class behavior.

image

Additionally, I have also contributed new unit tests for the OrganizationAddress class. These tests cover various methods of the OrganizationAddress class to ensure its functionality is thoroughly tested and validated.

Changes Made:

  1. Created OrganizationAddressTest.java in the src/test/java/org/openelisglobal/address/ directory.
  2. Implemented unit tests for the OrganizationAddress class methods, including setOrganizationId(), setAddressPartId(), setUniqueIdentifier(), getStringId(), and more.
  3. Added assertions to verify the correctness of the OrganizationAddress class behavior.

image

I have introduced two new unit test files:

  1. AddressPKTest.java: This test file validates the functionality of the AddressPK class.
    addressPK

  2. PersonAddressTest.java: This test file verifies the behavior of the PersonAddress class.

personalAddress

I added integration test and these tests ensure that the interaction between different classes

integrationTest

@sayed4900
Copy link
Contributor Author

can you review this PR @mozzy11 @caseyi ?

@manzil-infinity180
Copy link
Contributor

can you review this PR @mozzy11 @caseyi ?

one suggestion can you share the screenshot of passing test it will good for mentor @mozzy11

@sayed4900
Copy link
Contributor Author

can you review this PR @mozzy11 @caseyi ?

one suggestion can you share the screenshot of passing test it will good for mentor @mozzy11

Thanks for you suggestion, I added it on the description, thank you again.

Copy link
Contributor

@tendomart tendomart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sayed4900 remove unnecessary declarations, use fewer lines as possible.

@sayed4900
Copy link
Contributor Author

@sayed4900 remove unnecessary declarations, use fewer lines as possible.

I have removed them and make sure that everything is good, and make a new commit.
Thanks for you

@valens200
Copy link

valens200 commented Mar 15, 2024

Hello @sayed4900 could you please move the test folder named AddressPKTest under test.java.org.openelisglobal package?

@sayed4900
Copy link
Contributor Author

sayed4900 commented Mar 17, 2024

Hello @sayed4900 could you please move the test folder named AddressPKTest under test.java.org.openelisglobal package?

Isn't it in the right place?

@sayed4900
Copy link
Contributor Author

Can you review last changes?
@valens200 @tendomart

@sayed4900 sayed4900 mentioned this pull request Mar 19, 2024
@sayed4900
Copy link
Contributor Author

Can you review that?
@reagan-meant

@tendomart
Copy link
Contributor

do a git pull --rebase to re-align with the upstream branch

@mozzy11 mozzy11 merged commit bda4050 into I-TECH-UW:develop_3x Mar 21, 2024
@sayed4900
Copy link
Contributor Author

Thanks @mozzy11 for merge, I am very happy.

@mozzy11
Copy link
Collaborator

mozzy11 commented Mar 25, 2024

@sayed4900 , As a followup comment , these are not intergration tests.
can you create a subfolder unitTests under src/test/java/org/openelisglobal and move these these there too

@sayed4900
Copy link
Contributor Author

sayed4900 commented Mar 25, 2024

@sayed4900 , As a followup comment , these are not intergration tests. can you create a subfolder unitTests under src/test/java/org/openelisglobal and move these these there too

I do this on this pull request #891 but I add another folder called address under unitTests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants