Rewrite audit report trail #791
Conversation
|
Hi @mozzy11 @manishjha-04 @sherrif10 @CalebSLane This PR is ready for review now |
There was a problem hiding this comment.
hello @Lovelyfin00 , Nice progress.
Tis will require rewriting the actual report page in React
Hi @mozzy11 Yeah I did that. You can checkout the video I included in the description. When it comes to making the request, I called the endpoint but got an html response and not a json. So there was no way for me to display it which is why i had to redirect to the url |
|
yeah , |
|
👋 Hi, @Lovelyfin00, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
That makes alot of sense, thanks. Is there a way to get a correct accessionNumber @mozzy11 |
|
@Lovelyfin00 what do you mean to get the correct correct accessionNumber ?? |
I actually meant Lab No @mozzy11 |
|
Hi @mozzy11 |
|
Hello @Lovelyfin00 , addres the above comments , i can merge this in and Have some one who can complete the API |
|
Hi @mozzy11 refactor.mp4I keep seeing this error even though I have added the id to both translation files.
|
|
👋 Hi, @Lovelyfin00, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
| @@ -20,21 +21,18 @@ | |||
| "from.title": "De", | |||
| "to.title": "À", | |||
| "report.label.site.dateType": "Type de date", | |||
| "banner.menu.reports": "Rapports", | |||
There was a problem hiding this comment.
hey @Lovelyfin00 why was this line "banner.menu.reports": "Rapports", removed? what issue was it causing?
There was a problem hiding this comment.
@parthnagdev
Sorry, I just cross checked
I thought it was duplicated as a result of merge conflicts.
I can add it back right now
There was a problem hiding this comment.
I opened a PR for this
Fixes #761
Fix Summary
Audit Trail reportfrom JSP to new React UIScreen recording
12.03.2024_11.38.44_REC.mp4