Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added placeholder text to SearchPatientForm.js #743

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Added placeholder text to SearchPatientForm.js #743

merged 4 commits into from
Mar 21, 2024

Conversation

PR4NJ41
Copy link
Contributor

@PR4NJ41 PR4NJ41 commented Mar 3, 2024 •
edited
Loading

Resolves Issue #738

Before

Screenshot from 2024-03-04 04-41-08

After

Screenshot from 2024-03-04 04-40-08

@PR4NJ41
Copy link
Contributor Author

PR4NJ41 commented Mar 3, 2024 •
edited
Loading

@mozzy11 @gitcliff Please review my PR

sherrif10
sherrif10 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@sherrif10 sherrif10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @PR4NJ41

@sherrif10 sherrif10 mentioned this pull request Mar 4, 2024
Merged
CalebSLane
CalebSLane requested changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@CalebSLane CalebSLane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text should use the internationalization functionality available by using intl.formatMessage({}), providing a message key, and placing the english value in en.json. We also support French (fr.json), but that can be added independently of this commit.

@mozzy11
Copy link
Collaborator

mozzy11 commented Mar 21, 2024

@PR4NJ41 did you see @CalebSLane's request above ??

@mozzy11 mozzy11 merged commit 9fb9344 into I-TECH-UW:develop_3x Mar 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalebSLane CalebSLane CalebSLane requested changes

@sherrif10 sherrif10 sherrif10 approved these changes

@mozzy11 mozzy11 mozzy11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PR4NJ41 @mozzy11 @CalebSLane @sherrif10