Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search Functionality #730

Closed
wants to merge 8 commits into from
Closed

Add search Functionality #730

wants to merge 8 commits into from

Conversation

sherrif10
Copy link
Contributor

Hello @mozzy11 @CalebSLane .

Basing on this work, i got have two questions in mind perhaps i havent explored deeply,
Do we
1search for patient by identifier,
2. search for a patient by name,
3 or search for a patient by lab order or something.

what would be the right approach of managing this.

https://www.loom.com/share/e8aa6d75cecd44e89e2161fe4ecbb3ae

@sherrif10
Copy link
Contributor Author

sherrif10 commented Feb 27, 2024

here is the vedio, hopefully let me know what you think https://www.loom.com/share/2d3b2c9cf7da4518b96118d35dace122

@mozzy11
Copy link
Collaborator

mozzy11 commented Mar 1, 2024

can you fix the merge conflicts ??

@CalebSLane
Copy link
Contributor

@caseyi, asking for your input on this. What was the intended search functionality of the search icon located in the page header? Is it meant as a generic search that goes to Modify order page, patient page, etc?

@sherrif10
Copy link
Contributor Author

Hello @CalebSLane @mozzy11 Any designs required for this work ?

Copy link

👋 Hi, @sherrif10,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict Merge Conflicts label Mar 19, 2024
@github-actions github-actions bot added merge conflict Merge Conflicts and removed merge conflict Merge Conflicts labels Mar 19, 2024
Copy link

👋 Hi, @sherrif10,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@sherrif10
Copy link
Contributor Author

Hello @mozzy11 @CalebSLane @caseyi .What is your suggestion and direction on this PR.

@mozzy11
Copy link
Collaborator

mozzy11 commented Mar 22, 2024

Thanks @sherrif10 , for the start , we can start by supporting for searching for Patients by Patient Lab Number , First Name and Last Name

@mozzy11
Copy link
Collaborator

mozzy11 commented Mar 22, 2024

It should support Auto Complete

@sherrif10
Copy link
Contributor Author

Alright cool. i will implement that

@jona42-ui
Copy link
Contributor

jona42-ui commented Mar 24, 2024

@caseyi, asking for your input on this. What was the intended search functionality of the search icon located in the page header? Is it meant as a generic search that goes to Modify order page, patient page, etc?

do we already have a back end service for indexing and querying?
I think this would be very important to start with such that we can look at the basic acceptance criteria ,
ultimately we’ll want to specify some clear Acceptance Criteria about how we’ll want a search engine library(either elastic search or lucene) patient-related search to work.

@jona42-ui
Copy link
Contributor

another one maybe would be to know whether we already have a proposal for a suitable search engine to be used for all this work

@jona42-ui
Copy link
Contributor

I think about the search, as you have said maybe one can search by clicking the search icon and users are taken to a dedicated search results page or directly to relevant sections (e.g., Modify Order, Patient Details) based on their search query. but how do you deal with user permissions and roles here?

@sherrif10
Copy link
Contributor Author

Thanks @jona42-ui for the input.

as you have said maybe one can search by clicking the search icon and users are taken to a dedicated search results page or directly to relevant sections

As indicated on mozzys response, i think search results should be rendered may be in an overaly however basing on the patient lab NO. i have something am implementing , i will share a draft for the review.

@mozzy11 mozzy11 closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict Merge Conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants