-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search Functionality #730
Conversation
here is the vedio, hopefully let me know what you think https://www.loom.com/share/2d3b2c9cf7da4518b96118d35dace122 |
can you fix the merge conflicts ?? |
@caseyi, asking for your input on this. What was the intended search functionality of the search icon located in the page header? Is it meant as a generic search that goes to Modify order page, patient page, etc? |
Hello @CalebSLane @mozzy11 Any designs required for this work ? |
👋 Hi, @sherrif10, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
👋 Hi, @sherrif10, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Hello @mozzy11 @CalebSLane @caseyi .What is your suggestion and direction on this PR. |
Thanks @sherrif10 , for the start , we can start by supporting for searching for Patients by Patient Lab Number , First Name and Last Name |
It should support Auto Complete |
Alright cool. i will implement that |
do we already have a back end service for indexing and querying? |
another one maybe would be to know whether we already have a proposal for a suitable search engine to be used for all this work |
I think about the search, as you have said maybe one can search by clicking the search icon and users are taken to a dedicated search results page or directly to relevant sections (e.g., Modify Order, Patient Details) based on their search query. but how do you deal with user permissions and roles here? |
Thanks @jona42-ui for the input.
As indicated on mozzys response, i think search results should be rendered may be in an overaly however basing on the patient lab NO. i have something am implementing , i will share a draft for the review. |
Hello @mozzy11 @CalebSLane .
Basing on this work, i got have two questions in mind perhaps i havent explored deeply,
Do we
1search for patient by identifier,
2. search for a patient by name,
3 or search for a patient by lab order or something.
what would be the right approach of managing this.
https://www.loom.com/share/e8aa6d75cecd44e89e2161fe4ecbb3ae