Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added minor changes, #1355

Closed
wants to merge 3 commits into from
Closed

Conversation

Bahati308
Copy link
Contributor

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

Added some changes that solve errors that come along with running the mvn run format and npm spotless:apply and also changed port from 8080 to 9000 to avoid conflicts that arise

Screenshots

[Add relevant screenshots here if applicable]

Related Issue

[Add a link to the related issue or mention it here if applicable]

Other

[Add any additional information or notes here]

@adityadeshlahre
Copy link
Contributor

@Bahati308 these changes aren't required? may I know the reason of this PR working on something ?

@Bahati308
Copy link
Contributor Author

@Bahati308 these changes aren't required? may I know the reason of this PR working on something ?

Thanks @adityadeshlahre , I realised whenever I run the npm run format to sync the front end changes, Those changes keep getting generated automatically, which I think prettier does that and for changing port from 80 to 9000 in the dev.docker-compose, I experience port allocation issues on the ports assigned by default. I hope someone else might face the same challenges. And after changing to port 9000, it works just perfect.

@Bahati308 Bahati308 closed this Jan 2, 2025
@Bahati308 Bahati308 deleted the masterchief branch January 2, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants