1339: Save Button Disabled During API Call, Disllowing Multiple Requests #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @aayush6194 |
mozzy11
previously approved these changes
Dec 19, 2024
mozzy11
reviewed
Dec 19, 2024
| @@ -35,7 +35,7 @@ export const postToOpenElisServer = ( | |||
| callback, | |||
| extraParams, | |||
| ) => { | |||
| fetch( | |||
| return fetch( | |||
There was a problem hiding this comment.
@aayush6194 , we already pass a call back to the fetch function when it returns the Response.
you can revert this change here so that we are consistent across the API call utilities
mozzy11
reviewed
Dec 19, 2024
| @@ -330,7 +336,9 @@ function CreatePatientForm(props) { | |||
| days: "", | |||
| }); | |||
| }, | |||
| ); | |||
| ).then(() => { | |||
| setIsSubmitting(false); | |||
There was a problem hiding this comment.
you can instead set this directly in the call back here ,when the call returns the Response , like we do for the other post-Submit actions
|
Thanks @aayush6194 , just added a few minor comments , just make sure we have consistence across all the API call utilities |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests Requirements
Issue number if applicable.
documentation.
Summary
isSubmittingto track the state of the API call.isSubmittingis true.postToOpenElisServer()return a Promise, allowing to chain additional .then() handler