Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional tests for SearchResultsService #1333

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Add additional tests for SearchResultsService #1333

merged 4 commits into from
Dec 16, 2024

Conversation

rahul6603
Copy link
Contributor

@rahul6603 rahul6603 commented Dec 2, 2024 •
edited
Loading

Related Issue

#1049

Summary

  • This PR aims to add additional tests for searching by each parameter (firstName, lastName, dob and gender) separately for both DB and Lucene search.
  • I used the JUnitParams library to add parametrised test easily and in a more readable way.
  • I also added missing Asserts for gender.

@mozzy11
Copy link
Collaborator

mozzy11 commented Dec 16, 2024

Thanks @rahul6603

@mozzy11 mozzy11 merged commit 2677579 into I-TECH-UW:develop Dec 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozzy11 mozzy11 mozzy11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahul6603 @mozzy11