-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored the getSysUserId Method into a Single Class #1303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ariho-Seth for attempting this.
You need only to create a new Class ControllerUtills
under the util sub-folder and move the getSysUserId
there . We could add more commnUtils there
The new ControllerUtills
Class shoud not implement IActionConstants
. Leave that for or the BaseController
Then let the BaseController and BaseRestController Classes extend the new ControllerUtills
.
The rest of the controller Classes should only Extend either BaseController
or BaseRestController
respectively as it has been.
Hello @mozzy11 , please checkout that and tell me whether the solution is okay now! Thanks |
...main/java/org/openelisglobal/qaevent/controller/rest/ViewNonConformEventsRestController.java
Outdated
Show resolved
Hide resolved
...in/java/org/openelisglobal/qaevent/controller/rest/ReportNonConformEventsRestController.java
Outdated
Show resolved
Hide resolved
...penelisglobal/qaevent/controller/rest/NonConformingEventsCorrectionActionRestController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openelisglobal/notifications/rest/NotificationRestController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openelisglobal/common/util/ControllerUtills.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openelisglobal/common/util/ControllerUtills.java
Outdated
Show resolved
Hide resolved
Hello @mozzy11 I added the requested changes, Is it now good to go? |
Thanks @Ariho-Seth |
Pull Requests Requirements
Issue number if applicable.
documentation.
Summary
Screenshots
Refactor getSysUserId into a Separate Class
#1222
Other
Created a new class ie ControllerUtills and moved the
protected String getSysUserId
method into the new class. Then refactored all the classes that were initialy extending the BaseRestController to extend the ControllerUtills class