Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for MenuService #1217

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Add tests for MenuService #1217

wants to merge 14 commits into from

Conversation

Agaba-derrick
Copy link
Contributor

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm the OpenElis Global x3 Styleguide and design
    documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

Screenshots

Screenshot from 2024-08-02 11-20-27

Related Issue

Add intergration Tests for menu #1216

Other

@mozzy11 kindly review this

mherman22
mherman22 reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@mherman22 mherman22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Agaba-derrick please run mvn spotless:apply to fix the formatting of this PR and fix the failing build

@Agaba-derrick
Copy link
Contributor Author

Screenshot from 2024-08-03 22-14-43

@Agaba-derrick Agaba-derrick requested a review from mherman22 August 3, 2024 19:22
mherman22
mherman22 suggested changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@mherman22 mherman22 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Agaba-derrick try to align your test methods to some of the suggestions i have added otherwise this looks fine already

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved
src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved
src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved
src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved
src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved
src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved
src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved
src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved
src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved
@Agaba-derrick Agaba-derrick requested a review from mherman22 August 4, 2024 16:02
mherman22
mherman22 approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@mherman22 mherman22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏿

cc: @mozzy11

mozzy11
mozzy11 requested changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@mozzy11 mozzy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Agaba-derrick for adding more Intergration tests for the Menu Service,
However am seeing alot of added test which are simply units test and not Integration TEsts for the Menu service.
Can you remove those

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved
src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved
src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved
src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved
@Agaba-derrick Agaba-derrick requested a review from mozzy11 August 5, 2024 13:32
@Agaba-derrick
Copy link
Contributor Author

@mozzy11 i notice that even after running maven spotless:apply the CI builds still fail !!

mozzy11
mozzy11 requested changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@mozzy11 mozzy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Agaba-derrick for the PR.
Can you remove all the methods that dont test the MenuService ??

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved
@Agaba-derrick Agaba-derrick requested a review from mozzy11 August 23, 2024 10:19
@Agaba-derrick
Copy link
Contributor Author

Thanks @Agaba-derrick for the PR. Can you remove all the methods that dont test the MenuService ??
yes sure

@github-actions GitHub Actions
Copy link

👋 Hi, @Agaba-derrick,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict Merge Conflicts label Oct 11, 2024
@github-actions github-actions bot removed the merge conflict Merge Conflicts label Oct 18, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @Agaba-derrick,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict Merge Conflicts label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mherman22 mherman22 mherman22 approved these changes

@mozzy11 mozzy11 Awaiting requested review from mozzy11

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
merge conflict Merge Conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Agaba-derrick @mozzy11 @mherman22