-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to JS to Purge in place #29
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works in my testing in 1.35.
"purge-failed": "Purge failed" | ||
"purge-failed": "Cache Purge failed", | ||
"tooltip-n-purge-ext": "Purge cache of the current page", | ||
"accesskey-n-purge-ext": "~" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have -n-
in these messages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because that’s the appropriate message key for tooltip and quick access key. -n- is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The -n-
in other messages means 'navigation' and is used for items e.g. in the sidebar. If any shorthand should be used, it'd be -ca-
, but really there's no need outside of core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm that’s weird I said n but added another comment right after mentioning -ca- then pushed a change making them ca.
I see in some extensions not used, but in others it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah no worries, -ca-
is good :)
What is the blocker of this? Is the fact this is a breaking change? I'm looking forward to this. |
mw-notify()
is now available by default.Per Breaking changes for 1.35 release