Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PLATE-680: fix docker image default permissions issues #5197

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

farioas
Copy link
Member

@farioas farioas commented Dec 14, 2023

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit 82e0e9d
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/65b917072dd118000859998f
😎 Deploy Preview https://deploy-preview-5197--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit 82e0e9d
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/65b9170734dd950007388a7a
😎 Deploy Preview https://deploy-preview-5197--heartex-docs.netlify.app/guide/billing
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the fix label Dec 14, 2023
@farioas farioas changed the title fix: PLATE-680: Rework Dockerfile fix: PLATE-680: fix docker image default permissions issues Jan 25, 2024
This reverts commit c3ef53b.
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.88%. Comparing base (4e0f517) to head (82e0e9d).
Report is 828 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5197   +/-   ##
========================================
  Coverage    75.88%   75.88%           
========================================
  Files          154      154           
  Lines        12931    12931           
========================================
  Hits          9813     9813           
  Misses        3118     3118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jombooth jombooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good (great, actually) - I'm not sure I've fully wrapped my head around the implications of having a built python wheel inside our Docker image instead of installing the project, sans wheel build, with poetry like we used to. This does feel like the right way forward, for example because it's more similar to our pip package, so I'm in favor.

deploy/docker-entrypoint.sh Outdated Show resolved Hide resolved
deploy/docker-entrypoint.sh Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
deploy/docker-entrypoint.d/common/30-run-db-migrations.sh Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@farioas farioas marked this pull request as draft January 29, 2024 22:31
@farioas farioas marked this pull request as ready for review January 30, 2024 15:34
@farioas
Copy link
Member Author

farioas commented Jan 30, 2024

/docker build

Workflow run
Docker image was pushed with the tag

@robot-ci-heartex
Copy link
Collaborator

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@robot-ci-heartex
Copy link
Collaborator

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants