-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for using dynamic orders in harl #71
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctory_visualization_merged
…ile, add potting and delivery event support
… graphs in single notebook)
… every object, add events_list field in trajectory
- Configuring recipes if needed (as they are used inside orders) - Fixing save_trajectories methiod - change outdated comment/variable name inside save_traj_as_json
Agent that is slowed down version of another agent. Can be used to produce assymetry of power between agents.
- Prioritization of pots where there is less ingredients left for ideal recipe. - Choosing next ingredient in the way that reveal intention for entire recipe.
- Tests for slowed down agents - Tests for pedagogical ingredients picking - Testing both GreedyHumanModel and SimpleGreedyHumanModel
- Standarization of ingredients list (sorted lisf of tuples) as method - ingredients_diff (used in GreedyHumanModel) - More tests
- one_hot_joint_action_encoding - sparse_categorical_joint_action_encoding - multi_hot_orders_encoding - check for featurize_state if layout can be featurized - gym space for every encoding method (besides action ones)
Probably nothing changed besides order_ids. This version was used in last tests
without this change there are false positives sometimes
bmielnicki
requested review from
mesutyang97,
micahcarroll and
nathan-miller23
and removed request for
mesutyang97 and
micahcarroll
March 11, 2021 11:24
Given that this is a lower priority issue right now, I'll temporarily close this PR for bookeeping – we can re-open it in the future if we are interested in exploring this direction further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes that are needed so my harl changes HumanCompatibleAI/human_aware_rl#16 can work.
Includes changes from #38 and #57 and: