Ensure safe_to_tensor moves tensors to the specified device.

[ernestum]

This PR fixes a bug in the safe_to_tensor utility: previously it did not move tensors to a new device according to the device kwarg which caused issues when there is more than one device available.
The bug went unnoticed for a long while since our circleCI runners do not have GPUs enabled.

Thanks to @tomtseng for drafting a fix for this in #828

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.76%. Comparing base (a8b079c) to head (5820cfe).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
+ Coverage   95.69%   95.76%   +0.07%     
==========================================
  Files         102      102              
  Lines        9645     9640       -5     
==========================================
+ Hits         9230     9232       +2     
+ Misses        415      408       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ernestum]

I think the coverage warning in this one is spurious. Can you merge this @AdamGleave ?

[AdamGleave]

I think the coverage warning in this one is spurious. Can you merge this @AdamGleave ?

Looks like the issue is that test_sqil_performance_continuous is being skipped. This is going to continue to cause a problem in all subsequent PRs requiring manual override -- we try and enforce 100% test coverage to make sure nothing is being unintentionally not run. I think you can just add a # pragma: no cover to fix this. If that doesn't work LMK and I can try to troubleshoot.

[dominikonysz]

Hello, what's the state of this PR?

[ChenJiangxi]

In the latest version I downloaded, this problem is still not solved.

[tomtseng]

I can take a look at merging this later this week, but there a bunch of new CI failures that I would need to resolve due to various versions changing in CI or packages over the past year that this PR has sat dormant.

In general no one is actively maintaining this repository now so if there are issues you may need to fork the repo and handle it yourself.

[tomtseng]

Made a bunch of misc changes to fix CI, it would've been better for me to make them a separate PR but I'm not sure I would've been able to get a code owner to review the PR. I'll just list the changes in this comment.

doctest had an error:

Exception raised:
    Traceback (most recent call last):
      File "/usr/lib/python3.8/doctest.py", line 1336, in __run
        exec(compile(example.source, filename, "single",
      File "<doctest default[0]>", line 38, in <module>
        dagger_trainer.train(8_000)
      File "/venv/lib/python3.8/site-packages/imitation/algorithms/dagger.py", line 669, in train
        trajectories = rollout.generate_trajectories(
      File "/venv/lib/python3.8/site-packages/imitation/data/rollout.py", line 447, in generate_trajectories
        obs, rews, dones, infos = venv.step(acts)
      File "/venv/lib/python3.8/site-packages/stable_baselines3/common/vec_env/base_vec_env.py", line 206, in step
        return self.step_wait()
      File "/venv/lib/python3.8/site-packages/imitation/algorithms/dagger.py", line 285, in step_wait
        _save_dagger_demo(traj, traj_index, self.save_dir, self.rng)
      File "/venv/lib/python3.8/site-packages/imitation/algorithms/dagger.py", line 147, in _save_dagger_demo
        serialize.save(npz_path, [trajectory])
      File "/venv/lib/python3.8/site-packages/imitation/data/serialize.py", line 23, in save
        huggingface_utils.trajectories_to_dataset(trajectories).save_to_disk(p)
      File "/venv/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 1470, in save_to_disk
        fs, _ = url_to_fs(dataset_path, **(storage_options or {}))
      File "/venv/lib/python3.8/site-packages/fsspec/core.py", line 383, in url_to_fs
        chain = _un_chain(url, kwargs)
      File "/venv/lib/python3.8/site-packages/fsspec/core.py", line 323, in _un_chain
        if "::" in path
    TypeError: argument of type 'PosixPath' is not iterable

fixed in 30f9048 by casting the PosixPath to a str.

unit-test-windows didn't have pytest installed, this was because the install dependencies CI step silently failed (silence fixed in 637bed5). The step failed because an indirect dependency pywinpty was failing to build with

    = note: ld: cannot find -lktmw32: No such file or directory\x90\x8d
  
  
  error: could not compile `winpty-rs` (build script) due to 1 previous error
  warning: build failed, waiting for other jobs to finish...
  💥 maturin failed
    Caused by: Failed to build a native library through cargo
    Caused by: Cargo build finished with "exit code: 101": `"cargo" "rustc" "--message-format" "json-render-diagnostics" "--manifest-path" "C:\\Users\\circleci\\AppData\\Local\\Temp\\pip-install-j4bmps1w\\pywinpty_d47bf837a6ea40b2a74b0e02c806c1bf\\Cargo.toml" "--release" "--lib"`
  Error: command ['maturin', 'pep517', 'build-wheel', '-i', 'C:\\Users\\circleci\\project\\venv\\Scripts\\python.exe', '--compatibility', 'off'] returned non-zero exit status 1
  [end of output]

I couldn't figure out how to properly fix this but I happened to notice that this didn't happen in newer Python versions so I just changed the windows CI tests to use python 3.9 instead of 3.8.

unit-test-macos didn't have commands virtualenv and python3.9 so I installed them.

mypy had some new errors:

/venv/lib/python3.8/site-packages/torch/_dynamo/mutation_guard.py:2: error: disable_error_code: Invalid error code(s): method-assign  [misc]
/venv/lib/python3.8/site-packages/torch/_dynamo/eval_frame.py:2: error: disable_error_code: Invalid error code(s): method-assign  [misc]
/venv/lib/python3.8/site-packages/torch/_dynamo/debug_utils.py:2: error: disable_error_code: Invalid error code(s): method-assign  [misc]
src/imitation/policies/base.py:38: error: Incompatible types in assignment (expression has type "ndarray[Any, Any]", variable has type "DictObs")  [assignment]
src/imitation/algorithms/adversarial/common.py:219: error: Self? has no attribute "parameters"  [attr-defined]
src/imitation/scripts/ingredients/demonstrations.py:39: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
src/imitation/algorithms/adversarial/gail.py:158: error: Self? not callable  [misc]
src/imitation/algorithms/adversarial/airl.py:118: error: Self? not callable  [misc]
src/imitation/algorithms/adversarial/airl.py:131: error: Self? has no attribute "base"  [attr-defined]

I ignored the torch ones in f64b3fc and fixed the remaining ones in 5820cfe.