Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement the kurtosis package to run manta parachain local #8

Merged
merged 7 commits into from
Oct 30, 2023

Conversation

shanithkk
Copy link
Collaborator

Description:

implement the kurtosis package to run manta parachain local

Commit Message

feat: implement the kurtosis package to run manta parachain local

see the guidelines for commit messages.

Changelog Entry

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@@ -0,0 +1,33 @@
def manta_run(plan,args):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change function to verb, Please follow a proper naming convention, (run_<chain/node name>)

)
)

def calamari_run(plan,args):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change function to verb, Please follow a proper naming convention, (run_<chain/node name>)

def run_calamari(plan,args):

exec_command = [ "bin/sh","-c","/usr/local/bin/manta --chain=calamari-local --wasm-execution=compiled --force-authoring --port 30333 --rpc-port 9944 --rpc-external --rpc-cors all --rpc-methods=Unsafe -- --wasm-execution=compiled --chain=/app/rococo-local.json"]
parachain = plan.add_service(
Copy link
Contributor

@shreyasbhat0 shreyasbhat0 Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused variable 'parachain'

def run_manta(plan,args):

exec_command = [ "bin/sh","-c","/usr/local/bin/manta --chain=manta-local --wasm-execution=compiled --force-authoring --port 30333 --rpc-port 9944 --rpc-external --rpc-cors all --rpc-methods=Unsafe -- --wasm-execution=compiled --chain=/app/rococo-local.json"]
parachain = plan.add_service(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused variable

@@ -0,0 +1,31 @@
def run_manta(plan, args):
exec_command = ["bin/sh", "-c", "/usr/local/bin/manta --chain=manta-local --wasm-execution=compiled --force-authoring --port 30333 --rpc-port 9944 --rpc-external --rpc-cors all --rpc-methods=Unsafe -- --wasm-execution=compiled --chain=/app/rococo-local.json"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format this please

parachain/manta.star Outdated Show resolved Hide resolved
Comment on lines 18 to 19
exec_command = ["bin/sh", "-c", "/usr/local/bin/manta --chain=calamari-local --wasm-execution=compiled --force-authoring --port 30333 --rpc-port 9944 --rpc-external --rpc-cors all --rpc-methods=Unsafe -- --wasm-execution=compiled --chain=/app/rococo-local.json"]
plan.add_service(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please format this line

@shreyasbhat0 shreyasbhat0 merged commit d0fa387 into main Oct 30, 2023
1 check passed
@shreyasbhat0 shreyasbhat0 deleted the DIVE-199-Localnet-setup-for-Manta-Polkadot branch October 30, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants