Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding secret copy button for token #414

Merged
merged 1 commit into from
Oct 2, 2023
Merged

adding secret copy button for token #414

merged 1 commit into from
Oct 2, 2023

Conversation

nickgrato
Copy link
Contributor

why?

users want to grab their token with out having to go into the console and write code to grab it. This puts a copy button front and center in the hub details page.

Copy link
Contributor

@mikemorran mikemorran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!!

Just for my education and understanding, did you have to make any updates to components in lilypad for this PR? Did you already have 'eye-on' and 'eye' supported for the button component?

@nickgrato nickgrato merged commit 9e05364 into main Oct 2, 2023
15 checks passed
@nickgrato nickgrato deleted the feature/token-copy branch October 2, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants