Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes hub #410

Merged
merged 43 commits into from
Sep 18, 2023
Merged

Classes hub #410

merged 43 commits into from
Sep 18, 2023

Conversation

nickgrato
Copy link
Contributor

@nickgrato nickgrato commented Sep 6, 2023

The hub concept is used across the code base quite a bit obviously. A lot of the components and code know too much about the hub and the separation of concerns bleeds everywhere..This is a refactor to decuple some of the functionality and creating a hub class.

@nickgrato nickgrato changed the base branch from main to feature/blog September 7, 2023 23:29
Copy link
Contributor

@nikk15 nikk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the use of classes! 👏

client/classes/Hub.tsx Outdated Show resolved Hide resolved
client/components/modules/hubs/HubCard/HubCard.tsx Outdated Show resolved Hide resolved
client/services/hub.service.ts Outdated Show resolved Hide resolved
@nickgrato nickgrato requested a review from nikk15 September 15, 2023 16:39
Base automatically changed from feature/blog to main September 18, 2023 17:38
@nickgrato nickgrato merged commit 085560a into main Sep 18, 2023
15 checks passed
@nickgrato nickgrato deleted the classes-hub branch September 18, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants