Fix Hubs Cloud admin panel deploy by replacing ncp with fs-extra copy #5365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 16, 2022
|
Confirmed this resolved my issue and removed the hack workaround on my end. Thank you, @brianpeiris |
|
Thanks for verifying it! |
keianhzo
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #4208, the
ncpdependency we used to copy admin build files did not actually wait for the copy operations to complete, which caused the admin panel to break after the deploy.ncphas also been unmaintained for a while. This PR replacesncpwithfs-extrawhich is relatively lightweight, maintained, battle-tested, and has acopyfunction that is a drop-in replacement forncp.