Fix dependency installation error reporting and handling. #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exairnous
force-pushed
the
fix-installdeps-error-reporting
branch
from
c929b02 to
fdef458
Compare
False positives in the error reporting when installing dependencies caused confusion to users and sometimes led to the dependency not getting installed at all when false errors were detected and the install halted. Switch to relying solely on is_module_available to determine whether an install was successful and suppress errors unless they are 100% confirmed to be an issue. Make upgrading pip optional instead of required. Modify is_module_available to be able to check both system dependencies (i.e. pip) and locally installed dependencies. Modify is_module_available to explicitly return a bool.
Exairnous
force-pushed
the
fix-installdeps-error-reporting
branch
from
fdef458 to
41ac24b
Compare
|
@hrithikwins Can you check and see if this fixes #308 for you, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
False positives in the error reporting when installing dependencies caused confusion to users and sometimes led to the dependency not getting installed at all when false errors were detected and the install halted.
Switch to relying solely on is_module_available to determine whether an install was successful and suppress errors unless they are 100% confirmed to be an issue.
Make upgrading pip optional instead of required.
Modify is_module_available to be able to check both system dependencies (i.e. pip) and locally installed dependencies.
Modify is_module_available to explicitly return a bool.
This PR should hopefully address #308 as well as any other similar cases.