Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding confusing between Blender X axis and Threejs Y Axis #261

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

hrithikwins
Copy link
Contributor

Fixes the issue mentioned in #217

@hrithikwins
Copy link
Contributor Author

image

@keianhzo keianhzo self-requested a review December 18, 2023 10:23
Copy link
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if "Only Horizontal" is preferred over the proposed "Vertical Axis Only". Any ideas @j-conrad @Exairnous ?

@hrithikwins
Copy link
Contributor Author

Thanks @keianhzo @Exairnous @j-conrad for pointing out the wrong commits, now this is fixed with
image

@Exairnous
Copy link
Contributor

Thank you for the update @hrithikwins, this is looking much better! We discussed in the add-on meeting that there should probably be a reference to it affecting the world space and removing the other rotational transforms, so what would you (and the others) think of adding "in world space and removes any other rotational transforms" to the end of the tooltip?

@hrithikwins
Copy link
Contributor Author

Sure, so that would mean that the tooltip contains the text as

Locks the Vertical Axis to enable only side to side movement in world space and removes any other rotational transforms

@Exairnous
Copy link
Contributor

Sure, so that would mean that the tooltip contains the text as

Locks the Vertical Axis to enable only side to side movement in world space and removes any other rotational transforms

Yes, that is what I'm suggesting :)

@hrithikwins
Copy link
Contributor Author

Thanks Exairnous , the latest commit has the more descriptive description :)

@Exairnous
Copy link
Contributor

Thank you Hrithik.

@keianhzo @j-conrad is everybody happy with the current wording?

@hrithikwins
Copy link
Contributor Author

@keianhzo @j-conrad

@keianhzo keianhzo self-requested a review January 11, 2024 16:28
Copy link
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @hrithikwins

@keianhzo keianhzo merged commit c2d649f into Hubs-Foundation:master Jan 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants