Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR tries to improve TS typings.
The main changes:
unknown over any
unkown
is prefer overany
, as any disable type checking. See https://typescript-eslint.io/rules/no-explicit-any/Promise input and return type
The return type of the promise is the same as the input type, this way, TS can infer the proper return type of this code:
Export type declaration
I exported the main types that could be used in several circumstances, like wrapping swr into another function, or overriding default store (in that case, the
Store
interface is helpful)Typing the store
I typed the
Store
class as the key is an array, and the data is aCacheNode