Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HCC Dependencies to Latest NuGet Versions #519

Open
wants to merge 28 commits into
base: development
Choose a base branch
from

Conversation

ArielBlanco1990
Copy link
Contributor

@ArielBlanco1990 ArielBlanco1990 commented Dec 19, 2024

Related to Issue

Fixes #516

Description

This update focuses on updating the local dependencies of Hotcakes Commerce (HCC) to use the latest versions available on NuGet.

How Has This Been Tested?

Verified that the application builds successfully with the updated dependencies.
Tested key functionality in a local environment to confirm that the changes do not introduce regressions.
Reviewed areas of the code that interact with the updated dependencies to validate compatibility.

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@WillStrohl WillStrohl added this to the 04.00.00 milestone Jan 7, 2025
@WillStrohl
Copy link
Member

@WillStrohl Important note for myself... Merge the PR from Alejandro before this one.

Copy link
Member

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArielBlanco1990 Do you know of any reason to not update the .NET Framework to 4.8 instead of only 4.7.2?

Also, I see some updated CSS & image files in the PR. Why are these updates in the PR? What do they support?

*
* http://api.jqueryui.com/accordion/#theming
*/
.ui-accordion .ui-accordion-header {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArielBlanco1990 What are the updates in this file for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WillStrohl Apparently this was updated when jQuery was upgraded to a higher version, not added manually.

@ArielBlanco1990
Copy link
Contributor Author

@WillStrohl Regarding the .NET Framework version, I'm going to try to update it. I don't remember if I did it and I got some error. I'll update it to version 4.8 and perform a functional test. If everything is correct, I'll upload the change in the PR.

@ArielBlanco1990
Copy link
Contributor Author

@WillStrohl I have updated the .Net Framework version to version 4.8 and everything has worked correctly, I have uploaded the new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Update depenencies to nuget & latest releases
3 participants