chore: basic create react app #1621

jackcmeyer · 2019-09-09T00:29:43Z

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!

basic create react app
husky and commitizen
commitlint

More info can be found by clicking the "guidelines for contributing" link above.

jackcmeyer · 2019-09-09T00:35:21Z

Here is a PR for a basic create react app. It has basic create react app, husky, commitzen, and and commitlint. This should address all tasks that were in the issue.

I have marked it as WIP since I have the following questions.

Does this repository need its own eslint/prettier config?
Does this repository need .travis.yml enabled on it and its own .travis.yml config?
Does this repository need its own semantic release process enabled?
Should all of the .github templates be updated so that they can be standard across all repos? (Might be useful to create a template repo for the organization which standardizes formatting for issue/PR templates, README, contributing, etc.)

package.json

PhearZero

Update package.json to include @hospitalrun-org namespace and pre-commit hooks

PhearZero · 2019-09-09T01:31:30Z

@jackcmeyer

Does this repository need its own eslint/prettier config?

Does this repository need .travis.yml enabled on it and its own .travis.yml config?

Does this repository need its own semantic release process enabled?

Should all of the .github templates be updated so that they can be standard across all repos? (Might be useful to create a template repo for the organization which standardizes formatting for issue/PR templates, README, contributing, etc.)

Yes whatever CRA provides by default (react-app)
Yes but it is not a standard release cycle since we have dependent modules similar to Lerna projects. We do not want to release Feature X in the front end if Feature X is not implemented in the Server/Component libraries. This is done via the Mono-Repo Integration/E2E Acceptance hospitalrun#17 Organization Repository Acceptance hospitalrun#16
Yes it will be triggered on Master from a Mono-Repo Build
I like the way you think, Project documentation hospitalrun#8 and the old example in the PoC are going down that same path of thinking. We are going to have a standard storybook component DocumentationPage and CLI command called hospitalrun docs that will add any missing contribution guides, wrap readmes with headers and footers, and generate TSDocs to be used in Storybooks/wiki's etc.

jackcmeyer · 2019-09-09T02:29:32Z

@PhearZero I can start working on getting a templates repository put together. I think it's probably outside the scope of this PR

PhearZero · 2019-09-09T03:16:39Z

I can start working on getting a templates repository put together. I think it's probably outside the scope of this PR
@jackcmeyer Yea for sure lets head over to HospitalRun/hospitalrun#8 and I can get you up to date there

fox1t · 2019-09-09T08:15:04Z

commitlint.config.js

+module.exports = {
+  extends: ["gitmoji"],
+  parserPreset: {
+      parserOpts: {


@tehkapa is this compatible with the commit style you proposed?

theoretically, yes. however, I also extends this ['@commitlint/config-conventional']
@PhearZero did you use both solutions in your tests?

I really like conventional. In addition to it we need also to enforce referencing the issue the commits are addressing.

I started with config-conventional linting for testing locally and then added in alternative configurations in the PoC testing pnpm/husky. We could rewrite the history if need be

@fox1t @tehkapa

Is there anything that I need to do here?

This looks like it matches the config in the hospitalrun/hospitalrun repository. Also matches the config propoed in HospitalRun/hospitalrun-server#154

If we are changing, I would assume we would update this config to match hospitalrun/components

fox1t

Please remove all react logos: we will put ours instead.

package.json

fox1t · 2019-09-09T08:16:59Z

package.json

+    "eject": "react-scripts eject"
+  },
+  "eslintConfig": {
+    "extends": "react-app"


Is this eslintConfig compatible with TS? I can't see the language plugins.

It's what the CRA outputs with the --typescript flag. It's somewhere in react-scripts that handles all of the heavy lifting. Not very familiar with the cli yet. We could eject the app but we lose support from upstream

TypeScript CRA

fox1t · 2019-09-09T08:24:21Z

@jackcmeyer we will use always the same tsconfig. This is our FE config https://github.com/HospitalRun/components/blob/master/tsconfig.json
can you please ensure here are used the same compiler options?

Need more infos

PhearZero · 2019-09-09T18:06:48Z

@jackcmeyer we will use always the same tsconfig. This is our FE config https://github.com/HospitalRun/components/blob/master/tsconfig.json
can you please ensure here are used the same compiler options?

Just a note react-scripts ignores/overrides some tsconfig options so we may have to eject if we want full control or find a workaround. Ran into this issue trying to resolve module aliases

jackcmeyer · 2019-09-10T03:26:46Z

@PhearZero @fox1t

@jackcmeyer we will use always the same tsconfig. This is our FE config HospitalRun/components:tsconfig.json@master
can you please ensure here are used the same compiler options?

I've updated the tsconfig.json to match the components library. However, I was not able to use declarations and isolatedModules together so I dropped declarations support. Let me know if that is ok

matteovivona

proposed change to the dockerfile

Closes #1621

fox1t · 2019-09-12T13:39:37Z

@irvelervel what do you think about what is proposing @jackcmeyer?

irvelervel

Good to go!

jackcmeyer added 2 commits September 8, 2019 19:10

🚧 (app) Initial create react app

82df45e

✨ (lifecycle) Adds husky and commitizen

4b4c758

jackcmeyer requested review from fox1t, PhearZero and matteovivona September 9, 2019 00:29

jackcmeyer changed the base branch from master to next September 9, 2019 00:30

PhearZero reviewed Sep 9, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

PhearZero reviewed Sep 9, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

PhearZero suggested changes Sep 9, 2019

View reviewed changes

jackcmeyer added 2 commits September 8, 2019 21:23

🔧 (package) Updates namespace

7eeff25

🔧 (lifecycle) Adds precommit hook

c9bfadf

jackcmeyer marked this pull request as ready for review September 9, 2019 03:22

jackcmeyer changed the title ~~[WIP] Basic create react app~~ Basic create react app Sep 9, 2019

matteovivona changed the title ~~Basic create react app~~ chore: basic create react app Sep 9, 2019

matteovivona previously approved these changes Sep 9, 2019

View reviewed changes

matteovivona added v2.x core-team indicates that the issue will be completed by a core team member in progress indicates that issue/pull request is currently being worked on labels Sep 9, 2019

matteovivona assigned jackcmeyer Sep 9, 2019

matteovivona added this to the v2.0.0 milestone Sep 9, 2019

fox1t reviewed Sep 9, 2019

View reviewed changes

matteovivona self-requested a review September 9, 2019 08:17

fox1t reviewed Sep 9, 2019

View reviewed changes

chore: updates package.json

932ee81

PhearZero approved these changes Sep 9, 2019

View reviewed changes

fox1t self-requested a review September 9, 2019 12:55

PhearZero self-requested a review September 9, 2019 17:44

jackcmeyer added 2 commits September 9, 2019 22:19

chore: updates dev dependencies

4b30950

chore: updates tsconfig to match components library

3e35d33

jackcmeyer added 2 commits September 9, 2019 22:43

chore: removes react branding and adds hospital run branding

d198de2

chore: updates package.json to add cz-emoji from node_modules

edb008e

matteovivona requested review from irvelervel and removed request for PhearZero and matteovivona September 10, 2019 09:15

PhearZero and others added 2 commits September 11, 2019 13:01

🐳 (devops) Adding Basic Dockerfile

36a4980

Update robots.txt

a7d0a83

matteovivona suggested changes Sep 11, 2019

View reviewed changes

🐳 (devops) Updates Dockerfile

57b809f

Closes #1621

matteovivona self-requested a review September 12, 2019 13:16

PhearZero approved these changes Sep 12, 2019

View reviewed changes

matteovivona requested review from matteovivona and removed request for matteovivona September 12, 2019 13:29

irvelervel approved these changes Sep 12, 2019

View reviewed changes

matteovivona approved these changes Sep 12, 2019

View reviewed changes

matteovivona merged commit 04f2a19 into next Sep 12, 2019

delete-merged-branch bot deleted the create-react-app branch September 12, 2019 14:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: basic create react app #1621

chore: basic create react app #1621

jackcmeyer commented Sep 9, 2019 •

edited

Loading

jackcmeyer commented Sep 9, 2019

PhearZero left a comment

PhearZero commented Sep 9, 2019

jackcmeyer commented Sep 9, 2019

PhearZero commented Sep 9, 2019

fox1t Sep 9, 2019

matteovivona Sep 9, 2019

fox1t Sep 9, 2019

PhearZero Sep 9, 2019

jackcmeyer Sep 10, 2019 •

edited

Loading

fox1t left a comment

fox1t Sep 9, 2019

PhearZero Sep 9, 2019 •

edited

Loading

fox1t commented Sep 9, 2019

PhearZero commented Sep 9, 2019 •

edited

Loading

jackcmeyer commented Sep 10, 2019 •

edited

Loading

matteovivona left a comment •

edited

Loading

fox1t commented Sep 12, 2019

irvelervel left a comment

chore: basic create react app #1621

chore: basic create react app #1621

Conversation

jackcmeyer commented Sep 9, 2019 • edited Loading

jackcmeyer commented Sep 9, 2019

PhearZero left a comment

Choose a reason for hiding this comment

PhearZero commented Sep 9, 2019

jackcmeyer commented Sep 9, 2019

PhearZero commented Sep 9, 2019

fox1t Sep 9, 2019

Choose a reason for hiding this comment

matteovivona Sep 9, 2019

Choose a reason for hiding this comment

fox1t Sep 9, 2019

Choose a reason for hiding this comment

PhearZero Sep 9, 2019

Choose a reason for hiding this comment

jackcmeyer Sep 10, 2019 • edited Loading

Choose a reason for hiding this comment

fox1t left a comment

Choose a reason for hiding this comment

fox1t Sep 9, 2019

Choose a reason for hiding this comment

PhearZero Sep 9, 2019 • edited Loading

Choose a reason for hiding this comment

fox1t commented Sep 9, 2019

PhearZero commented Sep 9, 2019 • edited Loading

jackcmeyer commented Sep 10, 2019 • edited Loading

matteovivona left a comment • edited Loading

Choose a reason for hiding this comment

fox1t commented Sep 12, 2019

irvelervel left a comment

Choose a reason for hiding this comment

jackcmeyer commented Sep 9, 2019 •

edited

Loading

jackcmeyer Sep 10, 2019 •

edited

Loading

PhearZero Sep 9, 2019 •

edited

Loading

PhearZero commented Sep 9, 2019 •

edited

Loading

jackcmeyer commented Sep 10, 2019 •

edited

Loading

matteovivona left a comment •

edited

Loading