Refactor sockets #614
Open
Refactor sockets #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit follows Bitcoin PR20788 (and probably several followups), and introduces a Sock class to handle the lifetime of network sockets and associated SSL connection handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stems from Bitcoin PR20788, with the goal of making sockets handling safer and better encapsulated.
All direct accesses to SOCKET fds are now handled in the
Sockclass, which ensures that sockets and associated SSL sessions are closed properly on destruction.Finally, this PR switches Linux syscall to wait on sockets from
select()topoll(), achieving more flexibility in terms of usable fds, and possibly better performance.