SC132 related updates in transactions; Tests for the Lambo-transactions #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nastenko
commented
Oct 15, 2020
nastenko
commented
- SC132: Updates of the Lambo-transactions related to the modification of a nonce computation in SDK;
- AbstractRegularTransaction is now imported from SDK;
- Tests for the Lambo-transactions: BuyCarTransaction, CarDeclarationTransaction, SellCarTransaction.
… computation in SDK; AbstractRegularTransaction is imported from SDK; Transactions tests and fixes
i-Alex
suggested changes
Oct 20, 2020
| @Override | ||
| public List<NoncedBoxData<Proposition, NoncedBox<Proposition>>> getOutputData(){ | ||
| List<NoncedBoxData<Proposition, NoncedBox<Proposition>>> allBoxesData = new ArrayList<>(); | ||
| for(RegularBoxData regularBoxData: outputRegularBoxesData){ |
There was a problem hiding this comment.
I would prefer to have outputRegularBoxesData processed in AbstractRegularTransaction::getOutputData method, then call super method here.
| @Override | ||
| public List<NoncedBoxData<Proposition, NoncedBox<Proposition>>> getOutputData(){ | ||
| List<NoncedBoxData<Proposition, NoncedBox<Proposition>>> allBoxesData = new ArrayList<>(); | ||
| for(RegularBoxData regularBoxData: outputRegularBoxesData){ |
i-Alex
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.