[Switch] Fix OS_Switch::show_virtual_keyboard #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- was missing the p_multiline, p_cursor_start and p_cursor_end args (don't urgently need to do anything with those vars, the software keyboard already appears to handle cursor position for editing in the middle of text if that's where you press the touch screen first) - keyboard height is actually 400, and now reports as such - removed old printf debugging for hiding software keyboard, it's one of the only places where that remains and shouldn't still be present in release
halotroop2288
changed the title
halotroop2288
requested changes
Jan 20, 2024
- removed remaining printf debug on showing keyboard - restored swkbdInlineUpdate in main loop to original position after flushing event buffer (after confirming that running it before is not needed for it to work, like first thought)
- restored original indentation, previous commits used spaces instead of tabs
|
Thanks for doing the cleanup, I somehow completely missed that I hadn't actually removed the printf or the other lines with wrong indents. I'm taking this as a learning experience for next time, namely to keep in mind the style conventions and not just autopilot there, to review my changes more thoroughly before pushing and to probably do any further coding when more rested and not rocking 2 nights insomnia in a row 😅 |
halotroop2288
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of OS_Switch::show_virtual_keyboard is wrong, arguments list doesn't match the format os.show_virtual_keyboard expects:
os.h
virtual void show_virtual_keyboard(const String &p_existing_text, const Rect2 &p_screen_rect = Rect2(), bool p_multiline = false, int p_max_input_length = -1, int p_cursor_start = -1, int p_cursor_end = -1);os_switch.h:
virtual void show_virtual_keyboard(const String &p_existing_text, const Rect2 &p_screen_rect = Rect2(), int p_max_input_length = -1);This is why the show_virtual_keyboard method never executes any of the code within, despite everything else about the inline software keyboard from libnx otherwise largely working.