Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openhv 20230917 (new formula) #198745

Closed
wants to merge 1 commit into from

Conversation

Mailaender
Copy link

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

I can't use system dependencies due to Lua 5.1 being deprecated. #198735.

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core dotnet .NET use is a significant feature of the PR or issue labels Nov 23, 2024
@chenrui333 chenrui333 changed the title openhv: new formula openhv 20230917 (new formula) Nov 23, 2024
Formula/o/openhv.rb Outdated Show resolved Hide resolved
Formula/o/openhv.rb Outdated Show resolved Hide resolved
Formula/o/openhv.rb Outdated Show resolved Hide resolved
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@SMillerDev
Copy link
Member

If this needs to vendor Lua for the exact reason we don't want formula to vendor Homebrew dependencies, I think that makes it a bad fit for Homebrew/core.

https://docs.brew.sh/Acceptable-Formulae#stuff-that-requires-vendored-versions-of-homebrew-formulae

@Mailaender
Copy link
Author

I understand. Thought that building from source is preferred. Submitted Homebrew/homebrew-cask#193079 instead.

@Mailaender Mailaender closed this Nov 23, 2024
@Mailaender Mailaender deleted the openhv-20230917 branch November 23, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet .NET use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants