Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating QLMarkdown to use new repo #98284

Closed
wants to merge 2 commits into from

Conversation

joeyhoer
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:


According to this thread, development on the original QLMarkdown has been abandoned and development has been moved to a new maintainer.

@miccal miccal requested a review from vitorgalvao January 19, 2021 02:58
@vitorgalvao
Copy link
Member

From the documentation on forks:

Forks must have the vendor’s name as a prefix on the Cask’s file name and token. If the original software is discontinued, forks still need to follow this rule so as to not be surprising to the user. There are two exceptions which allow the fork to replace the main cask:

  • The original discontinued software recommends that fork.
  • The fork is so overwhelmingly popular that it surpasses the original and is now the de facto project when people think of the name.

None of those is true. The submitted fork is so unpopular it doesn’t even pass the notability threshold to be included in the main repos.

@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants