-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autofirma: Improve uninstall config #151676
Conversation
@cdalvaro Please try to add a zap stanza. The linked documentation provides some recommended methods to create it. |
aeabe63
to
1ed9891
Compare
Thank you for your suggestion @bevanjkay! I have already added the zap stanza. |
How can I relaunch the CI pipeline? I think it failed because of a temporary issue. |
Re-running CI for you @cdalvaro |
I think the CI / test autofirma (macOS-13, intel) is reaching a timeout because it is waiting for a sudo password. How can I solve it? |
This PR is related with #88469 |
@cdalvaro The installer is prompting the user with a GUI before continuing which is stalling out the installer. |
Right now this cask cannot be uninstalled because of an error related with the certificates it tries to uninstall:
Could we merge this PR and solve the issue with the password prompt in another PR? |
@cdalvaro If the installer cannot pass CI we would be looking to instead remove the cask. |
/rebase |
Find for 'AutoFirma ROOT' certificate before trying to remove it.
1ed9891
to
0cc3c71
Compare
Hi @bevanjkay, thank you for watching this PR. I don't think the CI will pass. The installer (when is manually executed) requires the user's password, and there is no way to change the install directory for another one with user permissions. This is an official application from the Spanish Government, so I think the right place to have the cask is in the official Homebrew's cask repo. However, I understand your policy. If you consider this cask should be removed. Please, close this PR. But I prefer not to be the one who removes this cask from your repository. Since many people may rely on it. Thank you again for your time. |
Closing as this cannot be merged. Let's continue with current state as long as possible. |
@p-linnane I don't believe that the current cask is functional headlessly as-is. I can't even stop the GUI installer without first closing my browser... |
After making any changes to a cask, existing or new, verify:
brew audit --cask --online autofirma
is error-free.brew style --fix autofirma
reports no offenses.brew uninstall --cask autofirma
worked successfully.Related with issue #50361