Handle TimeoutError in FC2WebSocket._main_loop #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #31.
Hopefully I understood original intent correctly:
_try_heartbeat
gets called after every received message or if there was no messages forheartbeat_interval
.Downside of the way it is done is the use of two
_try_heartbeat
calls, but it seems to be the easiest way to avoid sending heartbeat in response to error/end of stream message, when_main_loop
raises exception.Is
debug
a fitting log level for message about timeout? I used it becauseheartbeat
message itself isdebug
, but perhaps it should have beentrace
?