💚📝 Use trusted publishers workflow #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i-setup' into switch-to-trusted-publishers-pypi-setup
hf-kklein
reviewed
Oct 6, 2023
| 1. Fill out the metadata in the [`pyproject.toml`](pyproject.toml); Namely the package name and the dependencies which should be in sync with your `requirements.in`. | ||
| 2. Uncomment the lines in [`.github/workflows/python-publish.yml`](.github/workflows/python-publish.yml) | ||
| 3. In [your PyPI account create a new API token](https://pypi.org/manage/account/#api-tokens). You have to create a token valid for your entire account first, only when the initial push happened, you can create a new token whose scope is limited to this project. | ||
| 4. Copy the token and paste it as a new repository secret under `github.com/your-username/your-reponame/settings/secrets/actions/new`. The secrets name should be `PYPI_API_TOKEN` as in the last line of the workflow file you edited in step 2. |
There was a problem hiding this comment.
heißt das, wir brauchen den token nicht mehr? 🤩
There was a problem hiding this comment.
exakt, keine Tokens mehr notwendig :)
finde das auch sehr cool und sehr magisch ^^
hf-kklein
reviewed
Oct 6, 2023
README.md
Outdated
| 1. Fill out the metadata in the [`pyproject.toml`](pyproject.toml); Namely the package name and the dependencies which should be in sync with your `requirements.in`. | ||
| 2. Uncomment the lines in [`.github/workflows/python-publish.yml`](.github/workflows/python-publish.yml) | ||
| 3. In [your PyPI account create a new API token](https://pypi.org/manage/account/#api-tokens). You have to create a token valid for your entire account first, only when the initial push happened, you can create a new token whose scope is limited to this project. | ||
| 4. Copy the token and paste it as a new repository secret under `github.com/your-username/your-reponame/settings/secrets/actions/new`. The secrets name should be `PYPI_API_TOKEN` as in the last line of the workflow file you edited in step 2. | ||
| 3. Create a new environment in your GitHub repository and call it `release`. |
There was a problem hiding this comment.
maybe specify where? I don't remember seeing this setting anywhere. maybe add a link with placeholders like we did for release?
hf-kklein
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.