-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ibims from 0.1.6 to 0.1.11 #59
Conversation
a3406b9
to
7ad224a
Compare
Bumps [ibims](https://github.com/Hochfrequenz/intermediate-bo4e-migration-models) from 0.1.6 to 0.1.7. - [Release notes](https://github.com/Hochfrequenz/intermediate-bo4e-migration-models/releases) - [Commits](Hochfrequenz/intermediate-bo4e-migration-models@v0.1.6...v0.1.7) --- updated-dependencies: - dependency-name: ibims dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
7ad224a
to
59300f6
Compare
This PR depends on Hochfrequenz/pedantic-validator-framework#51 |
unittests/conftest.py
Outdated
set_sub_container = list(set_sub_container) | ||
set_base_container = list(set_base_container) | ||
set_sub_container_intersection = [] | ||
set_base_container_intersection = [] | ||
for item_sub in set_sub_container: | ||
set_base_remove_list = [] | ||
for item_base in set_base_container: | ||
if str(item_sub) in str(item_base): | ||
set_sub_container_intersection.append(item_sub) | ||
set_base_container_intersection.append(item_base) | ||
set_base_remove_list.append(item_base) | ||
break | ||
for item_base in set_base_remove_list: | ||
set_base_container.remove(item_base) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allein aus dem im docstring beschriebenen zweck versteh ich nicht, warum du nicht die intersection von set
verwendest oder sogar isdisjoint
? (letzteres liest sich ganz ähnlich... hab's aber nicht im detail geprüft). wenn das nen grund hat, kannste ihn ja kommentieren
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Das Problem in principle: Zwei Mengen A
und B
, die jeweils Submengen beinhalten A_i
und B_j
. Finde alle A_i
für die gilt: Es existiert mindestens ein B_j
, sodass A_i ⊆ B_j
ist.
Oder mehr am Beispiel: Die tatsächlichen Fehlermeldungen sind superlang. Daher hab ich in die Menge der expected_errors
nur relevante Auszüge reingeschrieben. Da hilft mir dann die normale intersection leider nicht.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aber ich schreib das nochmal besser in den docstring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A newer version of ibims exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps ibims from 0.1.6 to 0.1.7.
Release notes
Sourced from ibims's releases.
Commits
cc35f54
Use release-environment-based PyPI Publishing9192623
Bump pytest from 7.4.3 to 7.4.4 (#101)33befc5
Bump types-requests from 2.31.0.10 to 2.31.0.20231231 (#100)5b3aaaa
Bump coverage from 7.3.4 to 7.4.0 (#99)098209e
Bump black from 23.12.0 to 23.12.1 (#97)b306c5d
Bump coverage from 7.3.3 to 7.3.4 (#98)da357f7
Bump mypy from 1.7.1 to 1.8.0 (#96)86a0a41
Bump isort from 5.12.0 to 5.13.2 (#95)256cda6
Bump coverage from 7.3.2 to 7.3.3 (#93)fa4eb2a
Bump pylint from 3.0.2 to 3.0.3 (#94)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)