Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ibims from 0.1.6 to 0.1.11 #59

Merged
merged 12 commits into from
Jan 15, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 8, 2024

Bumps ibims from 0.1.6 to 0.1.7.

Release notes

Sourced from ibims's releases.

v0.1.7

What's Changed

Full Changelog: Hochfrequenz/intermediate-bo4e-migration-models@v0.1.6...v0.1.7

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jan 8, 2024
@dependabot dependabot bot requested a review from a team January 8, 2024 00:26
@github-actions github-actions bot enabled auto-merge (squash) January 8, 2024 00:26
@dependabot dependabot bot force-pushed the dependabot/pip/ibims-0.1.7 branch from a3406b9 to 7ad224a Compare January 8, 2024 00:49
Bumps [ibims](https://github.com/Hochfrequenz/intermediate-bo4e-migration-models) from 0.1.6 to 0.1.7.
- [Release notes](https://github.com/Hochfrequenz/intermediate-bo4e-migration-models/releases)
- [Commits](Hochfrequenz/intermediate-bo4e-migration-models@v0.1.6...v0.1.7)

---
updated-dependencies:
- dependency-name: ibims
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/ibims-0.1.7 branch from 7ad224a to 59300f6 Compare January 8, 2024 01:05
@lord-haffi lord-haffi self-assigned this Jan 13, 2024
@lord-haffi
Copy link
Collaborator

This PR depends on Hochfrequenz/pedantic-validator-framework#51

@lord-haffi lord-haffi changed the title Bump ibims from 0.1.6 to 0.1.7 Bump ibims from 0.1.6 to 0.1.8 Jan 13, 2024
@lord-haffi lord-haffi changed the title Bump ibims from 0.1.6 to 0.1.8 Bump ibims from 0.1.6 to 0.1.9 Jan 13, 2024
Comment on lines 19 to 33
set_sub_container = list(set_sub_container)
set_base_container = list(set_base_container)
set_sub_container_intersection = []
set_base_container_intersection = []
for item_sub in set_sub_container:
set_base_remove_list = []
for item_base in set_base_container:
if str(item_sub) in str(item_base):
set_sub_container_intersection.append(item_sub)
set_base_container_intersection.append(item_base)
set_base_remove_list.append(item_base)
break
for item_base in set_base_remove_list:
set_base_container.remove(item_base)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allein aus dem im docstring beschriebenen zweck versteh ich nicht, warum du nicht die intersection von set verwendest oder sogar isdisjoint? (letzteres liest sich ganz ähnlich... hab's aber nicht im detail geprüft). wenn das nen grund hat, kannste ihn ja kommentieren

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das Problem in principle: Zwei Mengen A und B, die jeweils Submengen beinhalten A_i und B_j. Finde alle A_i für die gilt: Es existiert mindestens ein B_j, sodass A_i ⊆ B_j ist.
Oder mehr am Beispiel: Die tatsächlichen Fehlermeldungen sind superlang. Daher hab ich in die Menge der expected_errors nur relevante Auszüge reingeschrieben. Da hilft mir dann die normale intersection leider nicht.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aber ich schreib das nochmal besser in den docstring.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 15, 2024

A newer version of ibims exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@github-actions github-actions bot merged commit ac10d5f into main Jan 15, 2024
11 checks passed
@github-actions github-actions bot deleted the dependabot/pip/ibims-0.1.7 branch January 15, 2024 11:10
@lord-haffi lord-haffi changed the title Bump ibims from 0.1.6 to 0.1.9 Bump ibims from 0.1.6 to 0.1.11 Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants