Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the library #7

Merged
merged 170 commits into from
Nov 20, 2023
Merged

Rewrite the library #7

merged 170 commits into from
Nov 20, 2023

Conversation

harrylewis
Copy link
Member

@harrylewis harrylewis commented Aug 21, 2023 •
edited
Loading

Description

This PR rewrites this library, with an emphasis on ..

  • Improved developer experience/interface
  • Wider coverage of Payrix API
  • Higher code coverage

Check out the updated README.md for more information.

The existing library code has been kept around for now, until a time when that code can be safely removed.

@harrylewis harrylewis marked this pull request as ready for review August 23, 2023 21:38
@harrylewis harrylewis self-assigned this Aug 23, 2023
@harrylewis
Bundle with new platform
4f55c66
@harrylewis
Add new BaseResource class
a9eb042
@harrylewis
Create resource, Payrix::Merchant
4f4448f
@harrylewis
Implement basic .retrieve method
bf9d9a0
@harrylewis
Raise error when resource cannot be found
2893479
@harrylewis
Allow API key to be configurable
f44ef6c
@harrylewis
Create dynamic snake-cased methods to access attributes
28240a1
@harrylewis
Implement basic method to #inspect resource
abdc989
@harrylewis
Support string or hash arguments
c82c049
@harrylewis
Allow single-level API expansion
a3c6993
@harrylewis
Allow object-oriented expansion of API resources
c34eb17
@harrylewis
Revert to supporting custom messaging in ResourceNotFound error
b20b72b
@harrylewis
Raise ResourceNotFound when ID is not passed
9775823
@harrylewis
Raise error when :expand key is not an rray
b9565ee
@harrylewis
Support deep expansion in API calls
31184ce
@harrylewis
Support converting snake-case to camel-case for expand
15e8c07
@harrylewis
Add # symbol to #inspect output
33dd90a
@harrylewis
Rename .define_expansion to .nested_object
d267a59
@harrylewis
Add support for expansion of nested collections
3c150d4
@harrylewis
Extract .retrieve operation to module
680b2a5
@harrylewis
Extract #camel_case method to Payrix::Utils module
918c828
@harrylewis
Ensure expand parameter contains trailing =
0ff3eb0
@harrylewis
Update Payrix configuration in test environment
ec84697
@harrylewis
Add specs for Payrix::APIOperations::Retrieve.retrieve
415f06a
@harrylewis
Introduce Payrix::ExpandParameter to handle expand parameter logic
7215984
@harrylewis
Use Payrix::ExpandParameter
01bf2d5
@harrylewis
Rename local variable
ed7cc79
@harrylewis
Remove unnecessary code
6ac9f2c
syedahmedhussaini
syedahmedhussaini approved these changes Nov 20, 2023
View reviewed changes
Copy link

@syedahmedhussaini syedahmedhussaini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I know Jasmine and Nitesh also looked at the gem rewrite deeply. Good to merge this to Main for this repo.

@harrylewis harrylewis merged commit 43d64a2 into main Nov 20, 2023
@harrylewis harrylewis deleted the v1 branch November 20, 2023 14:38
@harrylewis harrylewis restored the v1 branch November 20, 2023 15:59
@harrylewis harrylewis deleted the v1 branch December 4, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syedahmedhussaini syedahmedhussaini syedahmedhussaini approved these changes

@niteshpurohit niteshpurohit Awaiting requested review from niteshpurohit

Assignees

@harrylewis harrylewis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harrylewis @syedahmedhussaini