This repository has been archived by the owner on Apr 13, 2024. It is now read-only.
Migrate to launching shell as a child app #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than embedding Phoenix in an iframe, launch it as a child app and then use the provided AppConnection to communicate with it.
Observing window resize events and also using a ResizeObserver means every resize event gets reported twice.
Now that we launch phoenix as its own app, we don't have to care what its URL is. Perhaps at some point we could have a config for which shell app to launch instead.
|
This is ready, I think! Make sure to merge at the same time as HeyPuter/phoenix#77 |
AtkinsSJ
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than embedding Phoenix in an iframe, launch it as a child app and then use the provided AppConnection to communicate with it.
Note that
phoenixhas to be registered in Puter as an app for this to work, and this also relies on HeyPuter/puter#255 and the connected Puter.js changes.