Map Property Adjustment. #3125
Open
Map Property Adjustment. #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i know in all emulators map property partially broken, but even if this packets have similar names, they different. look like exists atleast some flags what can change only 0x199 |
* Dropped clif_maptypeproperty2() and merged it with clif_map_property(). * Renamed packet_maptypeproperty2 to packet_maptypeproperty and added support for 0x99b(ZC_MAPPROPERTY_R2). * clif_map_property_mapall() now redirects its clif_send() job to clif_map_property() which has dummy bl.
Signed-off-by: Kei <[email protected]>
MrKeiKun
force-pushed
the
adjust-map_property
branch
from
3de8d2e
to
9256a62
Compare
|
@MrKeiKun @4144 @MishimaHaruna what's the status on this, can it be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Thanks to @Kenpachi2k13
Issues addressed: #2892