Adds UDT_MOBID for getunitdata & setunitdata, which retrieves actual mob id

[bWolfie]

Pull Request Prelude

• I have followed proper Hercules code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Adds UDT_MOBID for getunitdata() and setunitdata.

This is necessary because getunitdata(<Mob GID>, UDT_CLASS) retrieves the Sprite ID for BL_MOB. Which means if you use it on a mob which was generated using db\mob_avail.txt, then you will not get the actual Monster ID.

Issues addressed:
N/A

[HerculesWSAPI]

This change is 

[AnnieRuru]

actually I was rewriting the hercules unit controller system
stable...AnnieRuru:34-setunitdata
and this fall in 1 of my TODO list

about this issue,
case UDT_CLASS: script_pushint(st, md->vd->class); break;
it should return md->class as you said
http://upaste.me/ed6c2196382229bc7#LC281
and should have another UDT_SPRITEID to return md->vd->class

after all, my original intention is to have setmobddata and setmoblook separated
http://herc.ws/board/topic/8974-script-command-setmobdata-getmobdata/?do=findComment&comment=65553

*setmoblook/getmoblook
I think the md->state.xxxx should go different script command with md->vd.xxxxx
so all md->vd.xxxxx will go into this script command
currently rathena mix them all together, but I think they should be separated

although now I also convince ... yeah having all in 1 might be better

yes, I am totally revamp this unit controller system ...

[bWolfie]

One more thing which is missing is unable to retrieve the the NPC is attached to. I.e. if you want to kill monsters using killmonster(), you can't retrieve the "Npc::OnEvent" for the mob.

[AnnieRuru]

I never encounter this problem, so its probably your bad scripting method
should place each group into separated event labels
and if you want to kill all monsters in the map, there are *killmonsterall and *killmonster with "All" flag

custom, so I make a plugin

#include "common/hercules.h"
#include "map/mob.h"
#include "map/script.h"
#include "common/HPMDataCheck.h"

HPExport struct hplugin_info pinfo = {
	"getmonsterlabel",
	SERVER_TYPE_MAP,
	"0.1",
	HPM_VERSION,
};

BUILDIN(getmonsterlabel) {
	struct mob_data *md = map->id2md( script_getnum(st,2) );
	if ( !md ) {
		ShowWarning( "buildin_getmonsterlabel: Error in finding object GID or target GID is not a monster.\n" );
		return false;
	}
	script_pushconststr( st, md->npc_event );
	return true;
}

HPExport void plugin_init(void) {
	addScriptCommand( "getmonsterlabel", "i", getmonsterlabel );
}

and get the script done as ...

prontera,155,185,5	script	qwer	1_F_MARIA,{
	monster "this", -1,-1, "--ja--", PORING, 10, strnpcinfo(NPC_NAME)+"::Onaaa";
	monster "this", -1,-1, "--ja--", POPORING, 10, strnpcinfo(NPC_NAME)+"::Onbbb";
	end;
Onaaa:
Onbbb:
	end;
}

prontera,160,185,5	script	asdf	1_F_MARIA,{
	.@count = getunits( BL_MOB, .@mobid, false, strnpcinfo(NPC_MAP) );
	for ( .@i = 0; .@i < .@count; ++.@i ) {
//		sscanf getmonsterlabel(.@mobid[.@i]), "%s::%s", .@npc_name$, .@label$; // f*cking sscanf doesn't work
//		if ( .@npc_name$ == "qwer" ) // alright, let's use regular expression
		if ( getmonsterlabel(.@mobid[.@i]) ~= "([^:]*)::([A-Za-z_]*)" )
			if ( $@regexmatch$[1] == "qwer" )
				unitkill .@mobid[.@i];
	}
	end;
}

by the way this question should be asked on the forum ....