Refactor _evaluate_omaha_cards and simplify it #110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _evaluate_omaha_cards is refactored and four new methods are added to simplify the orignal function:
def _count_suits
It returns a list of counts indexed by suit.
def _determine_flush_suit
It returns the flush suit index or -1 if no flush is possible.
def calculate_flush_value
def calculate_non_flush_value
Additionally magic numbers are replaced with named constants.
Closes #92