Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix events on minimal ui #531

Merged

Conversation

dgarciabriseno
Copy link
Contributor

@dgarciabriseno dgarciabriseno commented Feb 8, 2024

Summary

Fixes #527 and #528

Doesn't load CCMC events in minimal UI. A button is made for each set of events, so the CCMC events added the 2nd overlapping button.

Events were missing due to some missing HTML that the javascript code was looking for.
This was also broken when the CCMC events were added since some of the underlying HTML changed.

Testing

Enter the browser versions this change was tested on below.

browser version
firefox 115.7.0esr (64-bit)
chrome 121.0.6167.139 (Official Build) (arm64)
safari 17.2.1 (18617.1.17.11.12, 18617)
edge untested

@dgarciabriseno dgarciabriseno merged commit ac2cc56 into Helioviewer-Project:main Feb 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] - Minimal UI has two overlapping events buttons
1 participant