Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth zoom desktop #520

Merged

Conversation

dgarciabriseno
Copy link
Contributor

@dgarciabriseno dgarciabriseno commented Jan 24, 2024

For #519

This implements smooth zooming in/out for desktop browsers.

New Updates:

  • The zoom in/out buttons now animate zooming in and out.
  • Scrolling the mouse wheel now performs the same actions as pinching does on mobile devices.
  • event markers, info dialogs, and trajectories now maintain a constant size while zooming in/out (previously the markers would also grow/shrink).

Fixes:

  • Earth scale position in screenshots/movies on mobile devices is fixed. Previously the computation for the position of the scale box was wrong after smooth zooming in or out (This only affected mobile devices).
  • Computing the viewport region of interest now takes the smooth zoomed image scale into account by default.
  • Celestial body labels appearing behind the trajectory lines when it should be on top.

@dgarciabriseno dgarciabriseno merged commit 974af63 into Helioviewer-Project:main Jan 26, 2024
1 check passed
@dgarciabriseno dgarciabriseno mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant