Skip to content

Commit

Permalink
Fix empty links (again) (#423)
Browse files Browse the repository at this point in the history
* Revert "Fix empty links (#422)"

This reverts commit 3929160.

* Add sr-only text to empty links
  • Loading branch information
dgarciabriseno authored Dec 28, 2022
1 parent 3929160 commit a7d5abf
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 16 deletions.
17 changes: 2 additions & 15 deletions index.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,6 @@
embed
minimal
*/

function url(){
$url = sprintf(
"%s://%s",
isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] != 'off' ? 'https' : 'http',
$_SERVER['SERVER_NAME']
);
// Deal with localhost nonstandard ports
if ($_SERVER['SERVER_PORT'] != 80 && $_SERVER['SERVER_PORT'] != 443) {
$url .= ":".$_SERVER['SERVER_PORT'];
}
return $url;
}
$hv_output = getenv('HV_OUTPUT');
$outputType = false;

Expand Down Expand Up @@ -511,7 +498,7 @@ function url(){

<div id="logo">
<h1>
<span><a class="logo-icon fa fa-sun-o fa-fw" href="<?php echo url(); ?>" title="The Open-Source Solar and Heliospheric Data Browser"></a><a class="logo-text" href="<?php echo url(); ?>" title="The Open-Source Solar and Heliospheric Data Browser">Helioviewer.org</a></span>
<span><a class="logo-icon fa fa-sun-o fa-fw" href="" title="The Open-Source Solar and Heliospheric Data Browser"><span class="sr-only">Helioviewer.org</span></a><a class="logo-text" href="" title="The Open-Source Solar and Heliospheric Data Browser">Helioviewer.org</a></span>
</h1>
</div>

Expand Down Expand Up @@ -634,7 +621,7 @@ function url(){
<div class="dropdown-holder layersPresetsList" style="display:inline-block;">
<ul class="clearfix">
<li class="dropdown-main" style="width:30px">
<a href="#" id="images-presets-dropdown" class="text-button" title="Images presets" style="font-size:0.75em;width:15px"><span class="fa fa-th"></span> <!--fa-server fa-bars--></a>
<a href="#" id="images-presets-dropdown" class="text-button" title="Images presets" style="font-size:0.75em;width:15px"><span class="fa fa-th"></span> <!--fa-server fa-bars--><span class="sr-only">Layer presets</span></a>
<ul class="sub-menu">

</ul>
Expand Down
6 changes: 5 additions & 1 deletion resources/css/helioviewer-base.css
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,8 @@ a.light:hover {
#mouse-coords-x, #mouse-coords-y {
width: 40%;
display: inline-block;
}
}

.sr-only {
visibility: hidden;
}

0 comments on commit a7d5abf

Please sign in to comment.